Sync the blocks before invalidating them to ensure all nodes are on the right tip. Otherwise nodes[0] might stay on the "stale" block and the test fails (intermittently)
test: Add missing sync_all to feature_coinstatsindex #22313
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2106-testSync changing 1 files +1 −0-
MarcoFalke commented at 6:17 PM on June 22, 2021: member
-
test: Add missing sync_all to feature_coinstatsindex fafd9165e9
- DrahtBot added the label Tests on Jun 22, 2021
-
jamesob commented at 7:07 PM on June 22, 2021: member
crACK https://github.com/bitcoin/bitcoin/pull/22313/commits/fafd9165e911bf33d6212ca8a613b71878c82449
Adding this sync resolves intermittent timing issues and isn't at odds with the purpose of the test.
- MarcoFalke merged this on Jun 23, 2021
- MarcoFalke closed this on Jun 23, 2021
- MarcoFalke deleted the branch on Jun 23, 2021
- sidhujag referenced this in commit 1e297cd6ab on Jun 24, 2021
- gwillen referenced this in commit f8ca439f8f on Jun 1, 2022
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels