crypto: Fix K1/K2 use in ChaCha20-Poly1305 AEAD #22331

pull dhruv wants to merge 1 commits into bitcoin:master from dhruv:15649-followups changing 2 files +5 −4

dhruv commented at 4:52 PM on June 23, 2021: member
BIP324 mentions K1 is used for the associated data and K2 is used for the payload. The code does the opposite. This is not a security problem but will be a problem across implementations based on the HKDF key derivations.

BIP324 author Jonas Schnelli thinks a code update will be better than a BIP update.

If this PR is merged:
- We need to update the test vector 3 in BIP324

[crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD

BIP324 mentions K1 is used for the associated data and K2 is used for
the payload. The code does the opposite. This is not a security problem
but will be a problem across implementations based on the HKDF key
derivations.

cd37356ff9

DrahtBot added the label Utils/log/libs on Jun 23, 2021
benthecarman commented at 5:46 PM on June 23, 2021: contributor

Concept ACK
DrahtBot commented at 7:50 PM on June 23, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #20962 (Alter the ChaCha20Poly1305@Bitcoin AEAD to the new specification by jonasschnelli)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake requested review from jonasschnelli on Jun 24, 2021
theStack commented at 10:32 AM on June 24, 2021: member

Concept ACK
jonasschnelli commented at 8:30 AM on August 11, 2021: contributor

utACK cd37356ff9a1a3c2365c4fe3c716d1ca74185d73
jonasschnelli removed review request from jonasschnelli on Aug 11, 2021
fanquake renamed this:
~~[crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD~~
crypto: Fix K1/K2 use in ChaCha20-Poly1305 AEAD
on Aug 18, 2021
fanquake merged this on Aug 19, 2021
fanquake closed this on Aug 19, 2021
sidhujag referenced this in commit 1ca38972fc on Aug 20, 2021
laanwj referenced this in commit f41aa81c99 on Oct 21, 2021
dhruv added this to the "Done" column in a project

sidhujag referenced this in commit 3457504d34 on Oct 21, 2021
kittywhiskers referenced this in commit 359d945703 on Nov 1, 2021
kittywhiskers referenced this in commit df06dfa435 on Nov 3, 2021
pravblockc referenced this in commit 00486f7c1e on Nov 18, 2021
DrahtBot locked this on Aug 19, 2022

Contributors

Labels

Linked (view graph)

#15649 Add ChaCha20Poly1305@Bitcoin AEAD #23271 crypto: Fix K1/K2 use in the comments in ChaCha20-Poly1305 AEAD #27634 BIP324 tracking issue

crypto: Fix K1/K2 use in ChaCha20-Poly1305 AEAD #22331

Conflicts