Remove unused wallet pointer from wallet signals #22358

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2106-walletRefactor changing 4 files +18 −19

MarcoFalke commented at 8:55 AM on June 28, 2021: member

The signals are members of the wallet, so passing the pointer would be redundant even if it was used.

Also, fix with -> without, which was forgotten in commit ca4cf5cff6f.
Remove unused wallet pointer from NotifyTransactionChanged signal faf3640303
Remove unused wallet pointer from NotifyAddressBookChanged 8888cf45f5
MarcoFalke added the label Refactoring on Jun 28, 2021
MarcoFalke added the label Wallet on Jun 28, 2021
jonatack commented at 12:05 PM on June 28, 2021: member

Code review ACK 8888cf45f5e45b38cb830f9c94cafbf622e1fe5f also verified with/without lock cs_wallet status for each of the two functions and debian clang 11 debug build clean
promag commented at 1:07 PM on June 28, 2021: member

Code review ACK 8888cf45f5e45b38cb830f9c94cafbf622e1fe5f.
hebasto commented at 4:49 PM on June 28, 2021: member

Concept ACK.
theStack approved
theStack commented at 10:34 PM on June 28, 2021: member

Code review ACK 8888cf45f5e45b38cb830f9c94cafbf622e1fe5f
fanquake merged this on Jun 29, 2021
fanquake closed this on Jun 29, 2021
MarcoFalke deleted the branch on Jun 29, 2021
sidhujag referenced this in commit 0bd6604cca on Jun 29, 2021
gwillen referenced this in commit 4d0fe73399 on Jun 1, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels