Document how to update settings on and for the transifex website before and after branch-off of a new release.
(This is #21440, updated with the review feedback.)
ACK 92b8fdf9a1a4c2ae16198e2dfd29678ac6779e9b
The doc change looks good to me 👍
The following diff shows that this PR has applied the review suggestions from #21440. Specifically: (1, 2, 3)
diff --git a/./old/bitcoin/doc/release-process.md b/./new/bitcoin/doc/release-process.md
index c4ba5da..94bd75b 100644
--- a/./old/bitcoin/doc/release-process.md
+++ b/./new/bitcoin/doc/release-process.md
@@ -38,11 +38,11 @@ Release Process
that causes rejection of blocks in the past history.
- Clear the release notes and move them to the wiki (see "Write the release notes" below).
- Translations on Transifex
- - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with slug `[bitcoin.qt-translation-<RRR>x]` where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it.
+ - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with the slug `[bitcoin.qt-translation-<RRR>x]`, where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it.
- Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
- - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.
+ - Update the Transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in the first step. This identifies which resource the translations will be synchronized from.
- Make an announcement that translators can start translating for the new version. You can use one of the [previous announcements](https://www.transifex.com/bitcoin/bitcoin/announcements/) as a template.
- - Change the resource auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.
+ - Change the auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/master/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps, to prevent an auto-update from interfering.)
#### After branch-off (on master)
@@ -53,7 +53,7 @@ Release Process
- Update the versions.
- Create a pinned meta-issue for testing the release candidate (see [this issue](https://github.com/bitcoin/bitcoin/issues/17079) for an example) and provide a link to it in the release announcements where useful.
- Translations on Transifex
- - Change the auto-update URL for the new major version's resource away from `master` and to the branch e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. Do not forget this or it will keep tracking master's translations instead, drifting away from the specific major release.
+ - Change the auto-update URL for the new major version's resource away from `master` and to the branch, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. Do not forget this or it will keep tracking the translations on master instead, drifting away from the specific major release.
36 | @@ -37,6 +37,12 @@ Release Process 37 | - This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect 38 | that causes rejection of blocks in the past history. 39 | - Clear the release notes and move them to the wiki (see "Write the release notes" below). 40 | +- Translations on Transifex 41 | + - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with the slug `[bitcoin.qt-translation-<RRR>x]`, where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it.
- Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with the slug `[bitcoin.qt-translation-<RRR>x]`, where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.xlf` to create it.
done
36 | @@ -37,6 +37,12 @@ Release Process 37 | - This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect 38 | that causes rejection of blocks in the past history. 39 | - Clear the release notes and move them to the wiki (see "Write the release notes" below). 40 | +- Translations on Transifex 41 | + - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with the slug `[bitcoin.qt-translation-<RRR>x]`, where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it. 42 | + - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
Considering the recent translation update incident, I'd suggest to replace this (outdated?) instruction with the following:
"Assure that in the project workflow setting (1) the 'Translation Memory Fillup' is enabled, and (2) 'Translation Memory Context Matching' is disabled".
Done
Thanks for bringing it up, I don't expect transifex-migrate-resource.py to ever work again, for two reasons:
So if it can be replaced by something Transifex provides themselves that would be nice.
36 | @@ -37,6 +37,12 @@ Release Process 37 | - This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect 38 | that causes rejection of blocks in the past history. 39 | - Clear the release notes and move them to the wiki (see "Write the release notes" below). 40 | +- Translations on Transifex 41 | + - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with the slug `[bitcoin.qt-translation-<RRR>x]`, where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it. 42 | + - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource). 43 | + - Update the Transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in the first step. This identifies which resource the translations will be synchronized from. 44 | + - Make an announcement that translators can start translating for the new version. You can use one of the [previous announcements](https://www.transifex.com/bitcoin/bitcoin/announcements/) as a template. 45 | + - Change the auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/master/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps, to prevent an auto-update from interfering.)
- Change the auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/master/src/qt/locale/bitcoin_en.xlf`. (Do this only after the previous steps, to prevent an auto-update from interfering.)
Done
51 | @@ -46,6 +52,8 @@ Release Process 52 | 53 | - Update the versions. 54 | - Create a pinned meta-issue for testing the release candidate (see [this issue](https://github.com/bitcoin/bitcoin/issues/17079) for an example) and provide a link to it in the release announcements where useful. 55 | +- Translations on Transifex 56 | + - Change the auto-update URL for the new major version's resource away from `master` and to the branch, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. Do not forget this or it will keep tracking the translations on master instead, drifting away from the specific major release.
- Change the auto-update URL for the new major version's resource away from `master` and to the branch, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.xlf`. Do not forget this or it will keep tracking the translations on master instead, drifting away from the specific major release.
Done.
Approach ACK 92b8fdf9a1a4c2ae16198e2dfd29678ac6779e9b.
Document how to update settings on and for the transifex website before
and after branch-off of a new release.
These have been integrated into the script long ago.
ACK a16378e501199144b5aecda57d8bfbc014546764
ACK a16378e501199144b5aecda57d8bfbc014546764