Make PrecomputedData hold references instead of pointers? #22438

issue JeremyRubin opened this issue on July 13, 2021
  1. JeremyRubin commented at 7:22 PM on July 13, 2021: contributor

    It would be a lot cleaner and get rid of a bunch of messy asserts/not asserted pointers if these were references.

    In which situations would we need the API to allow us to not pass a precomputed data or a transaction into the checker?

    #21702 (review)

  2. JeremyRubin commented at 7:22 PM on July 13, 2021: contributor

    @sipa ^

  3. maflcko commented at 7:27 PM on July 13, 2021: member

    Should be fine to do as long as you add LIFETIMEBOUND where needed. See also https://github.com/bitcoin/bitcoin/pull/19426

  4. maflcko commented at 9:33 AM on May 6, 2022: member

    #22793 might fix this

  5. JeremyRubin closed this on Dec 16, 2022

  6. bitcoin locked this on Dec 16, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me