No need to keep an unused feature. If this is ever needed again, it can be added back trivially.
refactor: Remove unused "disconnectpool is nullptr" feature #22457
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2107-refactorDisconnectPool changing 2 files +10 −14-
MarcoFalke commented at 12:56 PM on July 15, 2021: member
-
fa8dff79ca
refactor: Remove unused disconnectpool is nullptr feature
The last use was removed in commit d831e711cab83c70bf2ded62fe33f484844e73dd
- DrahtBot added the label Refactoring on Jul 15, 2021
- DrahtBot added the label Validation on Jul 15, 2021
- MarcoFalke renamed this:
refactor: Remove unused disconnectpool is nullptr feature
refactor: Remove unused "disconnectpool is nullptr" feature
on Jul 15, 2021 -
jnewbery commented at 4:40 PM on July 15, 2021: member
I would have thought we'd want to go the other way and make
DisconnectedBlockTransactionsoptional in all functions that take it. In the case wherem_mempoolis null, it seems strange to instantiate an object and pass it around if it never gets used. -
MarcoFalke commented at 6:27 PM on July 15, 2021: member
Closing due to controversy
- MarcoFalke closed this on Jul 15, 2021
- MarcoFalke deleted the branch on Jul 15, 2021
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels