bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp #22464

1. 
   jonatack commented at 9:12 pm on July 15, 2021: member

   Closes #22459.
2. bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp e49d50cf40
3. DrahtBot added the label Tests on Jul 15, 2021
4. hebasto approved
5. 
   hebasto commented at 10:42 pm on July 15, 2021: member

   ACK e49d50cf40766120d4079f2ae6f5b33a5952c4d0, tested on Debian 10.10 (i386):

   • on master (a88fa1a555195af6543cdc802e8e1c2e1668dd38)

   0$ CONFIG_SITE=$PWD/depends/i686-pc-linux-gnu/share/config.site ./configure --enable-suppress-external-warnings
   1$ make -j 9 > /dev/null
   2ar: `u' modifier ignored since `D' is the default (see `U')
   3bench/peer_eviction.cpp: In function ‘void EvictionProtectionCommon(ankerl::nanobench::Bench&, int, std::function<void(NodeEvictionCandidate&)>)’:
   4bench/peer_eviction.cpp:30:51: warning: narrowing conversion of ‘(((uint64_t)(& bench)->ankerl::nanobench::Bench::epochs()) * (& bench)->ankerl::nanobench::Bench::epochIterations())’ from ‘uint64_t’ {aka ‘long long unsigned int’} to ‘std::vector<std::vector<NodeEvictionCandidate> >::size_type’ {aka ‘unsigned int’} inside { } [-Wnarrowing]
   5     std::vector<Candidates> copies{bench.epochs() * bench.epochIterations(), candidates};
   6                                    ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
   7ar: `u' modifier ignored since `D' is the default (see `U')
   8ar: `u' modifier ignored since `D' is the default (see `U')
   

   • with this PR

   0$ CONFIG_SITE=$PWD/depends/i686-pc-linux-gnu/share/config.site ./configure --enable-suppress-external-warnings
   1$ make -j 9 > /dev/null
   2ar: `u' modifier ignored since `D' is the default (see `U')
   3ar: `u' modifier ignored since `D' is the default (see `U')
   4ar: `u' modifier ignored since `D' is the default (see `U')
   

6. MarcoFalke merged this on Jul 16, 2021
7. MarcoFalke closed this on Jul 16, 2021

   ---

8. jonatack deleted the branch on Jul 16, 2021
9. sidhujag referenced this in commit 5d1d1115cc on Jul 23, 2021
10. gwillen referenced this in commit dd2645a060 on Jun 1, 2022
11. DrahtBot locked this on Aug 18, 2022

Contributors
jonatack hebasto

Labels
Tests