Closes #22459.
bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp #22464
pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:fix-32bit-narrowing-warning changing 1 files +2 −1-
jonatack commented at 9:12 PM on July 15, 2021: member
-
bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp e49d50cf40
- DrahtBot added the label Tests on Jul 15, 2021
- hebasto approved
-
hebasto commented at 10:42 PM on July 15, 2021: member
ACK e49d50cf40766120d4079f2ae6f5b33a5952c4d0, tested on Debian 10.10 (i386):
- on master (a88fa1a555195af6543cdc802e8e1c2e1668dd38)
$ CONFIG_SITE=$PWD/depends/i686-pc-linux-gnu/share/config.site ./configure --enable-suppress-external-warnings $ make -j 9 > /dev/null ar: `u' modifier ignored since `D' is the default (see `U') bench/peer_eviction.cpp: In function ‘void EvictionProtectionCommon(ankerl::nanobench::Bench&, int, std::function<void(NodeEvictionCandidate&)>)’: bench/peer_eviction.cpp:30:51: warning: narrowing conversion of ‘(((uint64_t)(& bench)->ankerl::nanobench::Bench::epochs()) * (& bench)->ankerl::nanobench::Bench::epochIterations())’ from ‘uint64_t’ {aka ‘long long unsigned int’} to ‘std::vector<std::vector<NodeEvictionCandidate> >::size_type’ {aka ‘unsigned int’} inside { } [-Wnarrowing] std::vector<Candidates> copies{bench.epochs() * bench.epochIterations(), candidates}; ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ ar: `u' modifier ignored since `D' is the default (see `U') ar: `u' modifier ignored since `D' is the default (see `U')- with this PR
$ CONFIG_SITE=$PWD/depends/i686-pc-linux-gnu/share/config.site ./configure --enable-suppress-external-warnings $ make -j 9 > /dev/null ar: `u' modifier ignored since `D' is the default (see `U') ar: `u' modifier ignored since `D' is the default (see `U') ar: `u' modifier ignored since `D' is the default (see `U') - MarcoFalke merged this on Jul 16, 2021
- MarcoFalke closed this on Jul 16, 2021
- jonatack deleted the branch on Jul 16, 2021
- sidhujag referenced this in commit 5d1d1115cc on Jul 23, 2021
- gwillen referenced this in commit dd2645a060 on Jun 1, 2022
- DrahtBot locked this on Aug 18, 2022
Labels