Changing I2P ports in addrman may wrongly skip some entries from "new" buckets #22470

issue vasild opened this issue on July 16, 2021

vasild commented at 4:26 PM on July 16, 2021: member

The problem was originally reported in #22450 (comment). This is a dedicated issue to track it independently because it is a different problem than the one reported in #22450 OP/description.

If the same I2P address appears in multiple new buckets, then the first time this loop finds that address, it'll update the port and reposition it in that bucket. Any subsequent times that the address is encountered, it will already have had its port updated so the inner loop will continue ...

Thanks, @jnewbery!
vasild added the label Bug on Jul 16, 2021
vasild referenced this in commit 24cad63539 on Jul 16, 2021
vasild commented at 4:41 PM on July 16, 2021: member

Fix pending at https://github.com/bitcoin/bitcoin/pull/22471
jonatack commented at 9:08 AM on July 17, 2021: member

Indeed, this was a good find by @jnewbery.
vasild referenced this in commit fe67f03d0f on Jul 19, 2021
vasild referenced this in commit d4b67c8ebc on Jul 19, 2021
MarcoFalke renamed this:
~~Changing I2P ports in addrman may wronly skip some entries from "new" buckets~~
Changing I2P ports in addrman may wrongly skip some entries from "new" buckets
on Jul 19, 2021
fanquake closed this on Jul 20, 2021
fanquake referenced this in commit 624a193330 on Jul 20, 2021
josibake referenced this in commit 4abcf2370c on Jul 21, 2021
hebasto referenced this in commit 90df9ac392 on Jul 22, 2021
sidhujag referenced this in commit 2a336a660b on Jul 23, 2021
fanquake referenced this in commit 5cf28d5203 on Aug 3, 2021
janus referenced this in commit c5da7c0c29 on Nov 5, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

vasild

jonatack

Labels

Bug

Linked (view graph)

#22450 addrman serialize: nNew was wrong, oh ow #22471 addrman: reset I2P ports in all "new" buckets #22496 addrman: Remove addrman hotfixes #22497 scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14)