addrman: Remove unused test_before_evict argument from Good() #22505

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2021-07-addrman-good-test-before-evict changing 3 files +4 −4

jnewbery commented at 1:02 PM on July 20, 2021: member

This has never been used in the public interface method since it was introduced in #9037.
fanquake added the label P2P on Jul 20, 2021

in src/addrman.h:544 in e6caaea0ea outdated

 541 |          EXCLUSIVE_LOCKS_REQUIRED(!cs)
 542 |      {
 543 |          LOCK(cs);
 544 |          Check();
 545 | -        Good_(addr, test_before_evict, nTime);
 546 | +        Good_(addr, true, nTime);

MarcoFalke commented at 2:51 PM on July 20, 2021:

nit: Might be good to use named args where fundamental literal types are used for clarity

        Good_(addr, /* test_before_evict */ true, nTime);

jnewbery commented at 3:18 PM on July 20, 2021:

done!

[addrman] Remove unused test_before_evict argument from Good()

This has never been used in the public interface method since it was
introduced in #9037.

f036dfbb69

jnewbery force-pushed on Jul 20, 2021
lsilva01 approved
lsilva01 commented at 6:35 PM on July 20, 2021: contributor

Tested ACK https://github.com/bitcoin/bitcoin/pull/22505/commits/f036dfbb692c4d44d0f59194d089ed0aa1096347 on Ubuntu 20.04.
theStack approved
theStack commented at 8:46 PM on July 20, 2021: member

Code-review ACK f036dfbb692c4d44d0f59194d089ed0aa1096347
fanquake merged this on Jul 21, 2021
fanquake closed this on Jul 21, 2021
jnewbery deleted the branch on Jul 21, 2021
sidhujag referenced this in commit 7baf6a896b on Jul 23, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#9037 net: Add test-before-evict discipline to addrman