doc: Adjust commit message template for the guix.sigs repo #22507

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2107-docGuixCommit changing 1 files +2 −2

MarcoFalke commented at 2:28 PM on July 20, 2021: member

Seems to be the most common template used, so adjust this here, too.
hebasto approved
hebasto commented at 2:33 PM on July 20, 2021: member

ACK fa3b92d20570c72a3178c693afb81e105849805f.

Curly braces could be skipped for clarity.
MarcoFalke commented at 2:42 PM on July 20, 2021: member

I like to always add them for clarity
in doc/release-process.md:139 in fa3b92d205 outdated
```
 135 | @@ -136,7 +136,7 @@ Commit your signature to guix.sigs:
 136 |  ```sh
 137 |  pushd ./guix.sigs
 138 |  git add "${VERSION}/${SIGNER}"/noncodesigned.SHA256SUMS{,.asc}
 139 | -git commit -m "Add ${VERSION} unsigned sigs for ${SIGNER}"
 140 | +git commit -m "Add ${SIGNER} Guix attestations for ${VERSION} non-codesigned"
```
laanwj commented at 2:47 PM on July 20, 2021:

Don't think this needs to mention "Guix", it's the guix signatures repository so that is implicit.

MarcoFalke commented at 3:49 PM on July 20, 2021:

I am also thinking if the sentence was proper English before.

Shouldn't it say "Add attestations by $SIGNER for $VERSION non-codesigned"?

laanwj commented at 4:07 PM on July 20, 2021:

Yes, that'd be even better I think.
DrahtBot added the label Docs on Jul 20, 2021
doc: Adjust commit message template for the guix.sigs repo fafade9c79
MarcoFalke force-pushed on Jul 20, 2021
hebasto approved
hebasto commented at 4:00 PM on July 20, 2021: member

re-ACK fafade9c79f55c186c1938ce3e27077d12dee6c5
laanwj commented at 4:07 PM on July 20, 2021: member

ACK fafade9c79f55c186c1938ce3e27077d12dee6c5
laanwj merged this on Jul 20, 2021
laanwj closed this on Jul 20, 2021
MarcoFalke deleted the branch on Jul 21, 2021
sidhujag referenced this in commit 668c76364c on Jul 23, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels