If settings.json exists, but cannot be read, we should error saying the permissions are incorrect, instead of immediately overwriting the file.
Fixes #22571
Util: don't overwrite existing but unreadable settings.json #22590
pull tylerchambers wants to merge 0 commits into bitcoin:master from tylerchambers:fix-22571 changing 0 files +0 −0-
tylerchambers commented at 5:27 PM on July 30, 2021: contributor
-
jarolrod commented at 5:32 PM on July 30, 2021: member
Please squash your commits. For guidance on squashing, see: CONTRIBUTING.md#squashing-commits
additionally the commit message should read:
util: don't overwrite existing settings.jsonor somthing similar, however you deem appropriate. - tylerchambers renamed this:
Don't overwrite settings.json if it exists but can't be read.
Util: don't overwrite existing but unreadable settings.json
on Jul 30, 2021 - tylerchambers closed this on Jul 30, 2021
-
tylerchambers commented at 5:41 PM on July 30, 2021: contributor
... I'm not sure what I just did here. I branched from master on my fork, which was out of date, and I was trying to fix that. hopefully nothing broke?
Will try again.
- DrahtBot locked this on Aug 16, 2022
