`make install` creates files/folders with bad permissions if custom umask is used #22595

issue xanoni opened this issue on August 1, 2021
  1. xanoni commented at 1:51 AM on August 1, 2021: none

    The make install script, which most users would run via sudo to install into /usr/local, will use the current umask of the root user when creating certain files and directories. If one uses a restrictive umask by default (e.g. umask 077), this means that only the root user will be able to use the full Bitcoin package.

    Expected behavior

    The install script creates all directories and files, including man pages, etc., with permissions 644 / 755.

    Actual behavior

    Certain folders are created using the default umask, e.g.:

    • /usr/local/share/man/man1/
    • /usr/local/lib/pkgconfig/
    • [...]

    This means that only root can access files in these folders and other users won't be able to read the man pages (for example).

    To reproduce

    $ ./autogen.sh
    $ make
    $ sudo -iu root
    % umask 077
    % make install
    

    System information

    OS: Linux bitcoind version: HEAD

  2. xanoni added the label Bug on Aug 1, 2021
  3. hebasto added the label Build system on Oct 24, 2022
  4. hebasto commented at 1:28 PM on December 9, 2022: member

    @xanoni

    Does #17127 fix this issue for you?

  5. willcl-ark commented at 1:46 PM on December 9, 2022: contributor

    It did on my systemâ„¢ :)

  6. xanoni commented at 8:21 AM on December 28, 2022: none

    @xanoni

    Does #17127 fix this issue for you?

    I'm currently unable to test this, so please don't wait for my feedback. Thank you.

  7. fanquake closed this on Feb 7, 2023

  8. bitcoin locked this on Feb 7, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 00:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me