Add missing const to CAddrMan::Check_() #22601

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2108-addrmanConstCheck changing 2 files +14 −11

MarcoFalke commented at 12:28 PM on August 2, 2021: member

No description provided.

Add missing const to CAddrMan::Check_()

Also: Always compile the function signature to avoid similar issues in
the future.

fa8629b98e

MarcoFalke closed this on Aug 2, 2021
MarcoFalke deleted the branch on Aug 2, 2021
jnewbery commented at 1:05 PM on August 2, 2021: member

I've cherry picked this commit into #20233

in src/addrman.h:747 in fa8629b98e

 742 |      }
 743 |  
 744 | -#ifdef DEBUG_ADDRMAN
 745 |      //! Perform consistency check. Returns an error code or zero.
 746 |      int Check_() const EXCLUSIVE_LOCKS_REQUIRED(cs);
 747 | -#endif

jonatack commented at 1:19 PM on August 2, 2021:

This patch builds and runs for me. Note, it completely removes the #ifdef DEBUG_ADDRMAN checks from src/addrman.h.

DrahtBot locked this on Aug 18, 2022

Contributors

MarcoFalke

jnewbery

jonatack