doc: Add release notes for 22570 (ignore banlist.dat) #22603

1. 
   MarcoFalke commented at 2:20 pm on August 2, 2021: member

   Follow-up to #22570
2. MarcoFalke added this to the milestone 23.0 on Aug 2, 2021
3. in doc/release-notes.md:73 in fae540b70a outdated

   65@@ -66,6 +66,13 @@ New RPCs
   66 Build System
   67 ------------
   68 
   69+Files
   70+-----
   71+
   72+* On startup, the list of banned hosts and networks (via `setban` RPC) in
   73+  `banlist.dat` is ignored. Bitcoin Core version 22.x is the only version that
   

   ---

   ---

   

   jonatack commented at 2:23 pm on August 2, 2021:

   (if I’m understanding your intention here)

   0  `banlist.dat` is ignored. Bitcoin Core version 22.x is the last version that
   

   ---

   

   flack commented at 2:27 pm on August 2, 2021:

   it’s the last version that can read .dat and the only version that can read .dat and write to .json, so you’re both right :-) Maybe just split it into two separate clauses?
4. vasild approved
5. 
   vasild commented at 2:30 pm on August 2, 2021: member

   ACK fae540b70ae41db08a5999c621fdd896dca8d423
6. 
   flack commented at 2:31 pm on August 2, 2021: contributor

   Does this need some more generic notice for upgrades from older versions? I.e. if you upgrade from .21 or earlier directly to 23.x, you will lose your banlist data, unless you upgrade to 22.x first and let it convert it, right?
7. 
   laanwj commented at 2:45 pm on August 2, 2021: member

   if you upgrade from .21 or earlier directly to 23.x, you will lose your banlist data,

   As I understand it you won’t actually lose the data, it will just become inaccessible, but the .dat will still be there. Which is good. Someone who notices it later could ostensibly download 0.21.x and run it once to convert the file.

8. 
   flack commented at 2:51 pm on August 2, 2021: contributor

   yes, but by the time they notice, a new json might already have been created with some new entries, and then you’d have to merge it somehow (or lose the new entries). Not a huge deal I guess, but it couldn’t hurt to spell out that scenario in the release notes. At least then you’ll have something to point to if someone opens a bug report about how their banlist is gone :-).
9. MarcoFalke force-pushed on Aug 2, 2021
10. DrahtBot added the label Docs on Aug 2, 2021
11. 
    MarcoFalke commented at 3:46 pm on August 2, 2021: member

    Pushed a more verbose version
12. vasild approved
13. 
    vasild commented at 3:51 pm on August 2, 2021: member

    ACK fa7a93ada2df8d88c9cd411b441110ae6ddec2c0
14. doc: Add release notes for 22570 (ignore banlist.dat) fa2c868886
15. in doc/release-notes.md:75 in fa7a93ada2 outdated

    70+-----
    71+
    72+* On startup, the list of banned hosts and networks (via `setban` RPC) in
    73+  `banlist.dat` is ignored and only `banlist.json` is considered. Bitcoin Core
    74+  version 22.x is the only version that can read `banlist.dat` and also write
    75+  it in `banlist.json`. If `banlist.json` already exsits, version 22.x will not
    

    ---

    ---

    

    flack commented at 3:52 pm on August 2, 2021:

    exsits => exists

    and maybe “write it to” instead of “write it in” ?

    ---

    

    MarcoFalke commented at 3:54 pm on August 2, 2021:

    Done, thx
16. MarcoFalke force-pushed on Aug 2, 2021
17. vasild approved
18. 
    vasild commented at 4:09 pm on August 2, 2021: member

    ACK fa2c868886a52352631d32c398d98a2740639e86
19. 
    tryphe commented at 4:27 am on August 3, 2021: contributor

    ACK fa2c868886a52352631d32c398d98a2740639e86
20. Zero-1729 approved
21. 
    Zero-1729 commented at 4:36 am on August 3, 2021: contributor

    ACK fa2c868886a52352631d32c398d98a2740639e86
22. in doc/release-notes.md:73 in fa2c868886

    65@@ -66,6 +66,16 @@ New RPCs
    66 Build System
    67 ------------
    68 
    69+Files
    70+-----
    71+
    72+* On startup, the list of banned hosts and networks (via `setban` RPC) in
    73+  `banlist.dat` is ignored and only `banlist.json` is considered. Bitcoin Core
    

    ---

    ---

    

    jonatack commented at 8:18 am on August 3, 2021:

    suggestions:

    • “(via the setban RPC or the GUI peers tab)”
    • “is now ignored and banlist.json is read instead.`
    • s/double check/verify/
    • s/22.x is/22.x was/ (if this is for the v23.0 release notes)

    ---

    

    MarcoFalke commented at 7:24 am on August 4, 2021:

    might do if I have to retouch. Otherwise this can be edited in the wiki in about 6 months
23. MarcoFalke merged this on Aug 4, 2021
24. MarcoFalke closed this on Aug 4, 2021

    ---

25. MarcoFalke deleted the branch on Aug 4, 2021
26. sidhujag referenced this in commit 6cb8e022bc on Aug 4, 2021
27. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke jonatack flack vasild laanwj tryphe Zero-1729

Labels
Docs

Milestone
23.0