Remove txindex migration code #22615

issue jnewbery openend this issue on August 3, 2021
  1. jnewbery commented at 11:10 am on August 3, 2021: member

    The txindex was moved to its own database in #13033. As part of that change, data migration functionality was added, allowing the txindex to be maintained across upgrade without having to rebuild the entire index from scratch:

    https://github.com/bitcoin/bitcoin/blob/5cf28d5203a6203355283ea59f071af6a468d239/src/index/txindex.cpp#L75-L90

    13033 was included in v0.17, released in October 2018 and EOL in August 2020. Anyone who hasn’t upgraded at this point is running unsupported code, and shouldn’t have expectations around upgrading their node without having to rebuild the index. We should simplify the code by removing the MigrateData() functionality.

  2. MarcoFalke commented at 11:15 am on August 3, 2021: member
    Concept ACK
  3. MarcoFalke commented at 11:44 am on August 3, 2021: member
    I presume the cleanest solution would be to remove all code and document that users wishing to recover the disk space, can use a full reset (-reindex)?
  4. jnewbery commented at 3:53 pm on August 3, 2021: member

    I presume the cleanest solution would be to remove all code and document that users wishing to recover the disk space, can use a full reset (-reindex)?

    Sounds reasonable

  5. fanquake added the label UTXO Db and Indexes on Aug 12, 2021
  6. laanwj closed this on Sep 16, 2021

  7. DrahtBot locked this on Oct 30, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me