Fix getbalance discrepency #2272

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:getbalancefix changing 2 files +3 −3

gavinandresen commented at 7:09 PM on February 4, 2013: contributor

Two changes:

Use IsConfirmed() instead of IsFinal(), so 'getbalance "*" 0' uses the same 'is this output spendable' criteria as 'getbalance'. Fixes issue #172.

And a tiny refactor to CWallet::GetBalance() (redundant call to IsFinal -- IsConfirmed calls IsFinal).

Fix getbalance discrepency

Two changes:

Use IsConfirmed() instead of IsFinal(), so 'getbalance "*" 0' uses the same
'is this output spendable' criteria as 'getbalance'. Fixes issue #172.

And a tiny refactor to CWallet::GetBalance() (redundant call to IsFinal -- IsConfirmed
calls IsFinal).
getbalance with no arguments and 'getbalance "*" 0' could return different different results,

d28bd8b7ca

Diapolo commented at 10:27 PM on February 4, 2013: none

Does this affect Bitcoin-Qt in a way we need to take care of? Just asking without any research...
BitcoinPullTester commented at 2:21 AM on February 5, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d28bd8b7ca2d0d9ad5f01e005b49acdd3a9eb917 for binaries and test log.
sipa commented at 6:26 PM on April 7, 2013: member

ACK
Diapolo commented at 6:38 AM on April 8, 2013: none

@sipa Can you comment to my question above ;)?
gavinandresen referenced this in commit 1829134afe on Apr 8, 2013
gavinandresen merged this on Apr 8, 2013
gavinandresen closed this on Apr 8, 2013
sipa commented at 2:00 PM on April 8, 2013: member

I don't think this influences the GUi in any way.
namecoin-qt referenced this in commit e913982d7a on Jun 10, 2013
gavinandresen deleted the branch on Nov 4, 2013
davispuh referenced this in commit dd7be967be on Feb 18, 2014
laudney referenced this in commit 2e4a784735 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#172 getbalance/getbalance '*' discrepancy