Addrman serialization/deserialization tests are currently in net_tests.cpp. Move them to addrman_tests.cpp with the rest of the addrman tests.
Reviewer hint: review using git diff --color-moved=dimmed-zebra
MOVEONLY: tests: Move addrman ser/deser tests to addrman_tests.cpp #22725
pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2021-08-move-addrman-tests changing 2 files +134 −131-
jnewbery commented at 12:46 PM on August 17, 2021: member
-
aaa6ad5455
[MOVEONLY] [tests] Move addrman ser/deser tests to addrman_tests.cpp
Addrman serialization/deserialization tests are currently in net_tests.cpp. Move them to addrman_tests.cpp with the rest of the addrman tests. Reviewer hint: review using `git diff --color-moved=dimmed-zebra`
- fanquake added the label Tests on Aug 17, 2021
-
Zero-1729 commented at 1:26 PM on August 17, 2021: contributor
Concept ACK
-
MarcoFalke commented at 1:39 PM on August 17, 2021: member
review ACK aaa6ad54554abd1666cb60285ed6f890698ca620 📺
<details><summary>Show signature and timestamp</summary>
Signature:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 review ACK aaa6ad54554abd1666cb60285ed6f890698ca620 📺 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p pUifbAv/ZAhkEB6Ya+XSusX1VfN4B1dq5FVt+tRDK3H416jrn4nJyCqsjRXO1KSW MUtPyrmntYcqioDdWSNQL5n4+jBdbGZx0c4x8BR+EgGynpxz27BWa+eReqUwBQHM ivIPMZYSreNcCmrBIUr0zRpbPE8hPXCk948klVACo8a0N/l3zKA5jUFJUb9eleZ/ iKPx3o8ILqmWUw7K+5SnSk0HwF0+uwZUqFU8Q0iTvT6BtpMYUB/86koxF2BguPbS ep66iyjubO8jyIds9HDhap8Qur/5AqMae8zq8zfa69pr6oOMG8lS8/EKAa4SeDvM /61d3aQwvzc2hT9pVtXvY9owko87GsinShzJCG57OItnI4KAsTpZ0XG4bbEtbhnz Qc3+zSnI5WRLHH0rY5kUXu97VkxYVIbx7TTL76mZ4iy6JT4HR9bHTCdqIRC2Wzpk rPPzrFf70KlsgQxeCNeqynissO8LeTYUdV2kgBrLlyg5DH07uPDVlAnYqJxRQfzu MENYe31n =jPb5 -----END PGP SIGNATURE-----Timestamp of file with hash
f5716a51de0be4a4dcc3523d09a9e5d8d30225a82156c3d1161a4d25fd7c53e7 -</details>
-
mjdietzx commented at 2:32 PM on August 17, 2021: contributor
ACK aaa6ad54554abd1666cb60285ed6f890698ca620
-
Saviour1001 commented at 3:04 PM on August 17, 2021: none
Concept ACK <code>aaa6ad5</code>
-
DrahtBot commented at 7:54 PM on August 17, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22697 (addrman: Remove CAddrMan::Clear() function by jnewbery)
- #20196 (net: fix GetListenPort() to derive the proper port by vasild)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- fanquake merged this on Aug 18, 2021
- fanquake closed this on Aug 18, 2021
- jnewbery deleted the branch on Aug 18, 2021
- sidhujag referenced this in commit 93a8afbc5e on Aug 20, 2021
- DrahtBot locked this on Aug 18, 2022
Labels