test: Use proper target in do_fund_send #22742

pull S3RK wants to merge 1 commits into bitcoin:master from S3RK:fix_22686 changing 1 files +1 −1
  1. S3RK commented at 8:13 am on August 19, 2021: member

    It seems there is a bug in the test in #22686, the code behaviour itself looks correct.

    Instead of verifying the scenario from #22670 with both upper_bound and lower_bound for the transaction amount, the tests verified lower_bound two times. This fix is to properly use function parameter instead of a variable from the scope. The test still passes with both values, so no code changes are required.

  2. test: fix bug in 22686 8dcbbbea64
  3. S3RK commented at 8:13 am on August 19, 2021: member
  4. fanquake added the label Tests on Aug 19, 2021
  5. fanquake requested review from instagibbs on Aug 19, 2021
  6. laanwj commented at 12:30 pm on August 19, 2021: member
    Please elaborate a bit, what kind of bug? How does it manifest? Does the test fail?
  7. achow101 commented at 4:07 pm on August 19, 2021: member
    ACK 8dcbbbea6486e9ab7d5e7397b82585141f9910bf
  8. MarcoFalke renamed this:
    test: fix bug in 22686
    test: Use proper target in do_fund_send
    on Aug 19, 2021
  9. MarcoFalke merged this on Aug 19, 2021
  10. MarcoFalke closed this on Aug 19, 2021

  11. fanquake added the label Needs backport (22.x) on Aug 20, 2021
  12. hebasto referenced this in commit 97e3a9c634 on Aug 20, 2021
  13. hebasto commented at 7:18 am on August 20, 2021: member
    Backported in #22629.
  14. hebasto removed the label Needs backport (22.x) on Aug 20, 2021
  15. hebasto referenced this in commit 88fb7e37ad on Aug 20, 2021
  16. laanwj referenced this in commit 4a25e39624 on Aug 26, 2021
  17. fujicoin referenced this in commit 0adedd0937 on Aug 27, 2021
  18. gwillen referenced this in commit f57e6ad5d9 on Jul 27, 2022
  19. gwillen referenced this in commit c9d0d0cbe4 on Aug 1, 2022
  20. DrahtBot locked this on Aug 20, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 19:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me