refactor: Avoid temporary vectors/uint256s in VerifyTaprootCommitment #22748

1. 
   sipa commented at 5:51 pm on August 19, 2021: member

   As XOnlyPubKey has a Span-based constructor, that can be used directly without needing to first convert the byte sequence into a vector, only to convert that to a uint256, which only then can then be passed as a span to the constructor.

   Reported by @ roconnor-blockstream.

2. MarcoFalke renamed this:
   Avoid temporary vectors/uint256s in VerifyTaprootCommitment
   refactor: Avoid temporary vectors/uint256s in VerifyTaprootCommitment
   on Aug 19, 2021
3. 
   MarcoFalke commented at 6:27 pm on August 19, 2021: member

   review ACK e0d8beec9b787b8ac6de18fa52bf1d8b95d7fe4b 🏀

   Signature:

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA512
    2
    3review ACK e0d8beec9b787b8ac6de18fa52bf1d8b95d7fe4b 🏀
    4-----BEGIN PGP SIGNATURE-----
    5
    6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    7pUgxawv+IFfgkNuN6TyoEw04+XoHnklWUzXzpdytfREZeM7teG/wcZoswLytxFhS
    8sU1M3EYbGvVtPcP9IRz9DgCuqFysIvSQHxRqLG/8td0C6Vl5sCWAFvU0ZUvSBASd
    9igDam6zDFI+bVcI0REKW7yG0g7TPn+Y1Fq8OnAfL5oimeHmyY/QqvjXWCF3QsCfZ
   10gVKrTvlnUC9RRCh+jDPNBPhYjpFQ3JxsWOTLQuX3eP2o/Szzst1IMzg3Nz44n0Q0
   11wgxvUG2kq/iCblQD6bPpG2e5hltjQPZ/oLzLRq5V78M2rmuZ36g1rmJcfsV6BKDp
   12FhCbQw/3qc0CS8V0wUiIdv8XkqsqnYoeRoEU2b6esvk2beB6NOy0KXu0nRnhRPhV
   13t/IquY1W2leJVRtb2G/4kDWb+Wj6vMpQKAK412NgzZcUKik3xIKPar/puF2EeEzX
   14VsQhTIT7qZRG1y0a2Hc9jpsdeSCZGuOtdbz9LFghJMABMv+oNIeOG8ZKwLNeGtew
   15lyaptGjm
   16=Or4k
   17-----END PGP SIGNATURE-----
   

   Timestamp of file with hash e81e3df6bf149ec59e6ac028b35980a8d9ac4ddc08d3d3b248e23c40c2b55863 -

4. DrahtBot added the label Consensus on Aug 19, 2021
5. DrahtBot added the label Refactoring on Aug 19, 2021
6. theStack approved
7. 
   theStack commented at 10:39 am on August 20, 2021: member

   Code-review ACK e0d8beec9b787b8ac6de18fa52bf1d8b95d7fe4b
8. Avoid temporary vectors/uint256s in VerifyTaprootCommitment

   As XOnlyPubKey has a Span-based constructor, that can be used directly
   without needing to first convert the byte sequence into a vector, only
   to convert that to a uint256, which only then can then be passed as a
   span to the constructor.

   2f0190320d
9. sipa force-pushed on Aug 20, 2021
10. Zero-1729 approved
11. 
    Zero-1729 commented at 8:58 pm on August 20, 2021: contributor

    crACK 2f0190320ddf45ff35f07950e8f01e8f15538043
12. benthecarman approved
13. 
    benthecarman commented at 4:48 pm on August 21, 2021: contributor

    ack 2f0190320ddf45ff35f07950e8f01e8f15538043
14. theStack approved
15. 
    theStack commented at 5:31 pm on August 21, 2021: member

    re-ACK 2f0190320ddf45ff35f07950e8f01e8f15538043
16. 
    jonatack commented at 4:38 pm on August 22, 2021: member

    ACK 2f0190320ddf45ff35f07950e8f01e8f15538043
17. fanquake merged this on Aug 23, 2021
18. fanquake closed this on Aug 23, 2021

    ---

19. sidhujag referenced this in commit 69b194b988 on Aug 23, 2021
20. DrahtBot locked this on Aug 23, 2022

Contributors
sipa MarcoFalke theStack Zero-1729 benthecarman jonatack

Labels
Refactoring Consensus