refactor: Avoid temporary vectors/uint256s in VerifyTaprootCommitment #22748

pull sipa wants to merge 1 commits into bitcoin:master from sipa:202108_xonlyspan changing 1 files +2 −2
  1. sipa commented at 5:51 PM on August 19, 2021: member

    As XOnlyPubKey has a Span-based constructor, that can be used directly without needing to first convert the byte sequence into a vector, only to convert that to a uint256, which only then can then be passed as a span to the constructor.

    Reported by @ roconnor-blockstream.

  2. MarcoFalke renamed this:
    Avoid temporary vectors/uint256s in VerifyTaprootCommitment
    refactor: Avoid temporary vectors/uint256s in VerifyTaprootCommitment
    on Aug 19, 2021
  3. MarcoFalke commented at 6:27 PM on August 19, 2021: member

    review ACK e0d8beec9b787b8ac6de18fa52bf1d8b95d7fe4b 🏀

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK e0d8beec9b787b8ac6de18fa52bf1d8b95d7fe4b 🏀
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgxawv+IFfgkNuN6TyoEw04+XoHnklWUzXzpdytfREZeM7teG/wcZoswLytxFhS
sU1M3EYbGvVtPcP9IRz9DgCuqFysIvSQHxRqLG/8td0C6Vl5sCWAFvU0ZUvSBASd
igDam6zDFI+bVcI0REKW7yG0g7TPn+Y1Fq8OnAfL5oimeHmyY/QqvjXWCF3QsCfZ
gVKrTvlnUC9RRCh+jDPNBPhYjpFQ3JxsWOTLQuX3eP2o/Szzst1IMzg3Nz44n0Q0
wgxvUG2kq/iCblQD6bPpG2e5hltjQPZ/oLzLRq5V78M2rmuZ36g1rmJcfsV6BKDp
FhCbQw/3qc0CS8V0wUiIdv8XkqsqnYoeRoEU2b6esvk2beB6NOy0KXu0nRnhRPhV
t/IquY1W2leJVRtb2G/4kDWb+Wj6vMpQKAK412NgzZcUKik3xIKPar/puF2EeEzX
VsQhTIT7qZRG1y0a2Hc9jpsdeSCZGuOtdbz9LFghJMABMv+oNIeOG8ZKwLNeGtew
lyaptGjm
=Or4k
-----END PGP SIGNATURE-----

    Timestamp of file with hash e81e3df6bf149ec59e6ac028b35980a8d9ac4ddc08d3d3b248e23c40c2b55863 -

    </details>

  4. DrahtBot added the label Consensus on Aug 19, 2021
  5. DrahtBot added the label Refactoring on Aug 19, 2021
  6. theStack approved
  7. theStack commented at 10:39 AM on August 20, 2021: member

    Code-review ACK e0d8beec9b787b8ac6de18fa52bf1d8b95d7fe4b

  8. Avoid temporary vectors/uint256s in VerifyTaprootCommitment
    As XOnlyPubKey has a Span-based constructor, that can be used directly
without needing to first convert the byte sequence into a vector, only
to convert that to a uint256, which only then can then be passed as a
span to the constructor.
    2f0190320d
  9. sipa force-pushed on Aug 20, 2021
  10. Zero-1729 approved
  11. Zero-1729 commented at 8:58 PM on August 20, 2021: contributor

    crACK 2f0190320ddf45ff35f07950e8f01e8f15538043

  12. benthecarman approved
  13. benthecarman commented at 4:48 PM on August 21, 2021: contributor

    ack 2f0190320ddf45ff35f07950e8f01e8f15538043

  14. theStack approved
  15. theStack commented at 5:31 PM on August 21, 2021: member

    re-ACK 2f0190320ddf45ff35f07950e8f01e8f15538043

  16. jonatack commented at 4:38 PM on August 22, 2021: member

    ACK 2f0190320ddf45ff35f07950e8f01e8f15538043

  17. fanquake merged this on Aug 23, 2021
  18. fanquake closed this on Aug 23, 2021
  19. sidhujag referenced this in commit 69b194b988 on Aug 23, 2021
  20. DrahtBot locked this on Aug 23, 2022
Contributors
sipaMarcoFalketheStackZero-1729benthecarmanjonatack
Labels
RefactoringConsensus
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 03:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me