fuzz: execute each file in dir without fuzz engine #22763

pull prakash1512 wants to merge 2 commits into bitcoin:master from prakash1512:issue-21461-execute-file-without-fuzz-engine changing 1 files +57 −2

prakash1512 commented at 5:50 PM on August 21, 2021: contributor

Rebased PR #21496

Fixes #21461

This supports whole directory runs of the fuzzing seeds without needing a fuzzing library.

Reviewers are also requested look at the issue #76 in bitcoin-core/qa-assets.

Testing instructions: To build without libFuzzer, exclude the sanitizers.

CC=clang CXX=clang++ ./configure BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" BDB_CFLAGS="-I${BDB_PREFIX}/include" --without-gui --with-zmq --enable-fuzz

Tests:

# clean and build
make clean
make -j "$(($(nproc)+1))"

# get qa-assets if you don't have already
git clone https://github.com/bitcoin-core/qa-assets

# existing way to feed 1 at a time, still supported
FUZZ=process_message src/test/fuzz/fuzz < qa-assets/fuzz_seed_corpus/process_message/1258dd51f2a5f3221b33a306279ef7290c5fca6d

# new with this PR: one at a time
FUZZ=process_message src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/process_message/1258dd51f2a5f3221b33a306279ef7290c5fca6d

# or multiple files at the same time
FUZZ=process_message src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/process_message/1258dd51f2a5f3221b33a306279ef7290c5fca6d qa-assets/fuzz_seed_corpus/process_message/322a92239d967fba9ef3035aca3cb3090da344b2 qa-assets/fuzz_seed_corpus/process_message/32c460293ac230ebe269a92c7941518d8b76c95a

# new with this PR: whole directory at a time
FUZZ=process_message src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/process_message

# or mix of files and directories at the same time
FUZZ=process_message src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/process_message/1258dd51f2a5f3221b33a306279ef7290c5fca6d qa-assets/fuzz_seed_corpus/process_message/322a92239d967fba9ef3035aca3cb3090da344b2 qa-assets/fuzz_seed_corpus/process_message/32c460293ac230ebe269a92c7941518d8b76c95a qa-assets/fuzz_seed_corpus/process_message/

# new with this PR: wildcard support
FUZZ=process_messages src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/process_messages/* 

# new with this PR: run all seeds in all targets, one target/directory at a time 
for D in qa-assets/fuzz_seed_corpus/*; do [ -d "${D}" ] && echo "${D##*/}" && FUZZ="${D##*/}" src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/"${D##*/}"; done

fuzz: execute each file in dir without fuzz engine c5de0d9dd4
fuzz: execute each file in dir without fuzz engine b5fa5dd282
DrahtBot added the label Tests on Aug 21, 2021
in src/test/fuzz/fuzz.cpp:183 in b5fa5dd282
```
 180 | +            test_one_input(buffer);
 181 | +            ++tested;
 182 | +            buffer.clear();
 183 | +        }
 184 | +    }
 185 | +    std::cout << "tested " << tested << " files\n";
```
ajtowns commented at 7:08 AM on October 15, 2021:

I think this message would be much better if it included the name of the fuzzer doing the testing. (Need to copy it into a global from initialize to make that happen)

Reporting the time taken might also be good?
ajtowns commented at 7:14 AM on October 15, 2021: member

I think the two commits here should be squashed together? Otherwise a clearer explanation of what they're both doing in the commit message is needed.

Concept ACK, and have tested the patch works reasonably against current master.
nosakhare1717 approved
DrahtBot added the label Needs rebase on Feb 3, 2022
DrahtBot commented at 4:11 PM on February 3, 2022: member



🐙 This pull request conflicts with the target branch and needs rebase.

<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
ajtowns deleted a comment on Feb 4, 2022
MarcoFalke commented at 9:13 AM on March 4, 2022: member

#https://github.com/bitcoin/bitcoin/pull/24472
MarcoFalke closed this on Mar 4, 2022
MarcoFalke referenced this in commit bf2c0fb2a2 on Mar 17, 2022
sidhujag referenced this in commit 16b7f5f572 on Mar 18, 2022
DrahtBot locked this on Mar 4, 2023

Contributors

Labels

Linked (view graph)

#76 addresses from addressbook's sending tab appear in listaccounts #21461 fuzz: Make it possible to execute each file in a directory without fuzz engine #21496 fuzz: execute each file in dir without fuzz engine #24472 fuzz: execute each file in dir without fuzz engine