refactor: hasher cleanup (follow-up to 19935) #22772

pull mzumsande wants to merge 2 commits into bitcoin:master from mzumsande:202108_hasher_cleanup changing 2 files +0 −15

mzumsande commented at 4:01 PM on August 22, 2021: member
Small follow-ups to #19935:
- Removal of unused KeyIDHasher class (comment in 19935)
- Removal of an outdated comment, which referred to an old problem with the no longer supported Boost 1.46 and boost::unordered_map, now replaced by std::unordered_map. (comment in 19935)
refactor: Remove unused KeyIDHasher 16652a93ea

doc: remove outdated comment

No longer relevant because Boost 1.46 is no longer supported and
std::unordered_map is used instead of boost::unordered_map in CCoinsMap.

4c69571e6e

DrahtBot added the label Refactoring on Aug 22, 2021
DrahtBot added the label Utils/log/libs on Aug 22, 2021
DrahtBot added the label Wallet on Aug 22, 2021
MarcoFalke removed the label Wallet on Aug 22, 2021
MarcoFalke removed the label Utils/log/libs on Aug 22, 2021
Zero-1729 approved
Zero-1729 commented at 5:56 PM on August 22, 2021: contributor

ACK 4c69571e6eeae2c03d59045ea102baa5fd1c3816

LGTM, agree, no need keeping the unused KeyIDHasher (esp. after 281fd1a4a032cded7f9ea9857e3e99fc793c714b) and the out of date comment in src/util/hasher.h.
theStack approved
theStack commented at 5:43 PM on August 23, 2021: member

ACK 4c69571e6eeae2c03d59045ea102baa5fd1c3816 🆗

Verified via git grep KeyIDHasher that the removed class is indeed not used anywhere and also checked that the comment is outdated.
Saviour1001 commented at 7:47 PM on August 23, 2021: none

Tested ACK <code>4c69571</code>
fanquake merged this on Aug 24, 2021
fanquake closed this on Aug 24, 2021
sidhujag referenced this in commit b57b963519 on Aug 24, 2021
mzumsande deleted the branch on Aug 27, 2021
DrahtBot locked this on Aug 27, 2022

Contributors

Labels