combinerawtransaction fails to properly combine transactions containing taproot inputs #22784

issue achow101 openend this issue on August 23, 2021
  1. achow101 commented at 10:33 pm on August 23, 2021: member

    If combinerawtransaction is given a transaction containing completed taproot spends, it will drop the signatures from those inputs. For 0.21, combinerawtransaction would actually cause an assertion failure - this was fixed by #21330. This is not a regression as combinerawtransaction never worked with txs with taproot inputs anyways. AFAICT, either taproot was not yet implemented, it hit an assertion, or it is broken.

    In any case, I don’t think this is particularly important to fix since the recommended workflow is to use PSBTs. But I am opening this issue to document this in case someone does come across this bug.

    Originally found by @roconnor-blockstream

  2. achow101 added the label Bug on Aug 23, 2021
  3. sipa commented at 10:40 pm on August 23, 2021: member
    At least the assertion fail should be fixed, I think. Backport #21330 to 0.21?
  4. bitcoin deleted a comment on Aug 30, 2021
  5. achow101 closed this on Oct 26, 2022

  6. bitcoin locked this on Oct 26, 2023


achow101 sipa

Labels
Bug


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me