test, doc: refer to the correct variable names in p2p_invalid_tx.py #22797

pull aitorjs wants to merge 1 commits into bitcoin:master from aitorjs:master changing 1 files +3 −3

aitorjs commented at 5:55 PM on August 25, 2021: contributor

tx_orphan_no_fee and tx_orphan_invalid don't exist as transactions.

Have been replaced by tx_orphan_2_no_fee and tx_orphan_2_invalid respectively.

Motivation: Comments are more accurate and easy understandable under the tests context (I think).

in test/functional/p2p_invalid_tx.py:144 in 86785d55e8 outdated

 141 | @@ -142,8 +142,8 @@ def run_test(self):
 142 |              ]
 143 |          }
 144 |          # Transactions that do not end up in the mempool

jonatack commented at 6:04 PM on August 25, 2021:

        # Transactions that do not end up in the mempool:

jonatack commented at 6:06 PM on August 25, 2021: member

ACK, would suggest naming the PR and commit something like test, doc: refer to the correct variable names in p2p_invalid_tx.py
aitorjs renamed this:
~~docs: tx_orphan_no_fee and tx_orphan_invalid dont exist as transactions in p2p_invalid_tx.py~~
test, doc: refer to the correct variable names in p2p_invalid_tx.py
on Aug 25, 2021
aitorjs force-pushed on Aug 25, 2021
theStack commented at 7:12 PM on August 25, 2021: member

Concept ACK

Thanks, and welcome as a new contributor! Can you squash the two commits, please?
DrahtBot added the label Tests on Aug 25, 2021
test, doc: refer to the correct variable names in p2p_invalid_tx.py 0d9fdd329e
aitorjs force-pushed on Aug 25, 2021
kristapsk approved
kristapsk commented at 9:19 PM on August 25, 2021: contributor

utACK 0d9fdd329e81cb171d687042290f4e6b1507d7f4
theStack approved
theStack commented at 11:52 PM on August 25, 2021: member

ACK 0d9fdd329e81cb171d687042290f4e6b1507d7f4 📃
fanquake merged this on Aug 26, 2021
fanquake closed this on Aug 26, 2021
sidhujag referenced this in commit b71e4b089a on Aug 28, 2021
DrahtBot locked this on Aug 26, 2022

Contributors

Labels