test: Check that non-signaling BIP125 tx can be replaced via parent #22809

1. 
   MarcoFalke commented at 5:34 pm on August 26, 2021: member

   While optout_child_tx in the test_no_inherited_signaling test is reported as “bip125-replaceable”, it is not directly replaceable. For example by bumping the fee of optout_child_tx. However, it is still replaceable indirectly via it’s BIP-125 signalling parent.

   Clarify this by extending the test.

2. DrahtBot added the label Tests on Aug 26, 2021
3. 
   DrahtBot commented at 8:42 pm on August 26, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

4. 
   Saviour1001 commented at 9:00 am on August 29, 2021: none

   Tested ACK 222273a
5. in test/functional/feature_rbf.py:628 in 222273adcc outdated

   623+            from_node=self.nodes[0],
   624+            utxo_to_spend=confirmed_utxo,
   625+            sequence=0xffffffff,
   626+            fee_rate=Decimal('0.03'),
   627+        )
   628+        self.wallet.get_utxo(txid=optout_child_tx['txid'])  # Update wallet utxo state
   

   ---

   ---

   

   mjdietzx commented at 2:28 pm on August 30, 2021:

   nit: could be useful to add an assertion that the child tx is no longer in the mempool?
6. 
   mjdietzx commented at 2:29 pm on August 30, 2021: contributor

   ACK 222273adcc6b56da89b937ed0530487c4f7644b2
7. test: Check that non-signaling BIP125 tx can be replaced via parent fa2e9de59f
8. MarcoFalke force-pushed on Aug 30, 2021
9. 
   MarcoFalke commented at 3:02 pm on August 30, 2021: member

   Good point. Added assertion
10. 
    mjdietzx commented at 3:07 pm on August 30, 2021: contributor

    reACK fa2e9de59f189fe37c3eeb63d79e09983e40a993
11. 
    josibake commented at 11:25 am on August 31, 2021: member

    ACK https://github.com/bitcoin/bitcoin/commit/fa2e9de59f189fe37c3eeb63d79e09983e40a993
12. 
    mjdietzx commented at 4:47 pm on September 1, 2021: contributor

    Tested ACK fa2e9de59f189fe37c3eeb63d79e09983e40a993
13. fanquake requested review from darosior on Sep 2, 2021
14. fanquake merged this on Sep 2, 2021
15. fanquake closed this on Sep 2, 2021

    ---

16. MarcoFalke deleted the branch on Sep 2, 2021
17. 
    darosior commented at 11:53 am on September 2, 2021: member

    post merge crACK fa2e9de59f189fe37c3eeb63d79e09983e40a993
18. sidhujag referenced this in commit 8cbb4b2cb9 on Sep 2, 2021
19. DrahtBot locked this on Sep 2, 2022

Contributors
MarcoFalke DrahtBot Saviour1001 mjdietzx josibake darosior

Labels
Tests