For some tests the reject reason wasn't cleared between runs and thus subsequent tests might (theoretically) fail to verify the correct reject reason.
test: Always clear reject reason in IsStandard tx test #22860
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2109-testRej changing 1 files +49 −71-
MarcoFalke commented at 7:42 AM on September 2, 2021: member
-
test: Always clear reject reason in IsStandard tx test fa1b08eb14
- fanquake added the label Tests on Sep 2, 2021
- ShubhamPalriwala approved
-
ShubhamPalriwala commented at 1:14 PM on September 2, 2021: contributor
Approach Ack fa1b08eb1413d547b5e322f20e6907b2f827a162 Introducing 2 separate functions to handle the manual logic is a great way to go ahead and follow the DRY principle in our codebase!
- benthecarman approved
-
benthecarman commented at 8:22 PM on September 2, 2021: contributor
ACK fa1b08eb1413d547b5e322f20e6907b2f827a162
- theStack approved
-
theStack commented at 3:36 PM on September 3, 2021: member
Code-review ACK fa1b08eb1413d547b5e322f20e6907b2f827a162
Nice improvement 🎉
- MarcoFalke merged this on Sep 3, 2021
- MarcoFalke closed this on Sep 3, 2021
- MarcoFalke deleted the branch on Sep 3, 2021
- sidhujag referenced this in commit df2f1eea57 on Sep 4, 2021
- DrahtBot locked this on Sep 3, 2022
Contributors
Labels