Currently Parsescript and others build a map as a static and it's not threadsafe -- these fields should be behind a mutex or initialized at compile time or something else.
Make ParseScript and friends threadsafe #22869
issue JeremyRubin opened this issue on September 2, 2021-
JeremyRubin commented at 11:34 PM on September 2, 2021: contributor
- JeremyRubin added the label Bug on Sep 2, 2021
- JeremyRubin added the label good first issue on Sep 2, 2021
-
MarcoFalke commented at 7:01 AM on September 3, 2021: member
I don't understand this issue. I tried
git grep --function-context 'ParseScript('|grep staticand didn't find anything. -
kristapsk commented at 8:11 AM on September 3, 2021: contributor
@MarcoFalke I found this one:
But as it's just a cache, why not just change it to
thread_local? -
MarcoFalke commented at 8:19 AM on September 3, 2021: member
That one seems to be addressed in #22875 already?
So I think this can be closed.
Also, in the future it would be good to use the good-first-issue template for good first issues.
- MarcoFalke removed the label good first issue on Sep 3, 2021
-
JeremyRubin commented at 8:32 AM on September 3, 2021: contributor
sorry for the confusion here
- JeremyRubin closed this on Sep 3, 2021
- DrahtBot locked this on Sep 3, 2022
Contributors
Labels