doc: Added hyperlink for doc/build #22880

Pradumnasaraf commented at 3:39 PM on September 3, 2021: contributor

Added hyperlink for the doc/build directory (https://github.com/bitcoin/bitcoin/tree/master/doc). This will be convenient for visitors to redirect. Screenshot (84)

DrahtBot added the label Docs on Sep 3, 2021

in INSTALL.md:4 in 16e110f1db outdated

   0 | @@ -1,5 +1,4 @@
   1 |  Building Bitcoin
   2 |  ================
   3 |  
   4 | -See doc/build-*.md for instructions on building the various
   5 | -elements of the Bitcoin Core reference implementation of Bitcoin.
   6 | +See <a href="https://github.com/bitcoin/bitcoin/tree/master/doc">doc/build-</a>*.md for instructions on building the various elements of the Bitcoin Core reference implementation of Bitcoin.

laanwj commented at 11:35 AM on September 9, 2021:

Please use a repo-relative link instead, don't want to either hardcode bitcoin/bitcoin or the branch master here
Please use markdown link syntax e.g. something like this should work, i think [doc/build-\*.md](/doc)

in INSTALL.md:4 in 8f56608800 outdated

   0 | @@ -1,5 +1,4 @@
   1 |  Building Bitcoin
   2 |  ================
   3 |  
   4 | -See doc/build-*.md for instructions on building the various
   5 | -elements of the Bitcoin Core reference implementation of Bitcoin.
   6 | +See [doc/build-\*.md](/doc) for instructions on building the various elements of the Bitcoin Core reference implementation of Bitcoin.

MarcoFalke commented at 12:14 PM on September 9, 2021:

See [doc/build-\*.md](/doc).

I think the whole file can be replaced by a simple <See link>. Though, that might just be me.

MarcoFalke commented at 12:15 PM on September 9, 2021: member

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

Pradumnasaraf commented at 12:51 PM on September 9, 2021: contributor

@MarcoFalke @laanwj Please check everything is ok?

MarcoFalke commented at 12:58 PM on September 9, 2021: member

You will need to rebase on current master

DrahtBot added the label Needs rebase on Sep 9, 2021

Pradumnasaraf commented at 1:13 PM on September 9, 2021: contributor

You will need to rebase on current master @MarcoFalke can you please guide me on how to do it properly I don't know how some errors occurred.

MarcoFalke commented at 1:20 PM on September 9, 2021: member

You can use a search engine to find out how to rebase with git: https://duckduckgo.com/?q=how+to+use+git

As the changes are small, I'd just reset the branch and start fresh: (Use at your own risk)

git checkout add-hyper-install.md
git fetch origin a5d00d4baff27b4185ea086af571142af17c32e4
git reset --hard a5d00d4baff27b4185ea086af571142af17c32e4

Then recreate the commit.

Pradumnasaraf commented at 1:56 PM on September 9, 2021: contributor

@MarcoFalke now you can check, look like everything is now finally ok😭

MarcoFalke approved

MarcoFalke commented at 2:03 PM on September 9, 2021: member

ACK 53b3bb5e09b02e4257de9868c2b0c98c2b97e2b9

MarcoFalke renamed this:
~~Added hyperlink for doc/build~~
doc: Added hyperlink for doc/build
on Sep 9, 2021

laanwj commented at 2:14 PM on September 9, 2021: member

The commit message "Added repo-relative link" is a bit confusing to people who just browse the change history. In general, try to make it interpretable independent of context or PR discussion history.

Changes ACK 53b3bb5e09b02e4257de9868c2b0c98c2b97e2b9

Pradumnasaraf commented at 2:16 PM on September 9, 2021: contributor

The commit message "Added repo-relative link" is a bit confusing to people who just browse the change history. In general, try to make it interpretable independent of context or PR discussion history.

Changes ACK 53b3bb5 @laanwj Noted. BTW when it will get merged?

laanwj commented at 2:18 PM on September 9, 2021: member

@laanwj Noted. Do I need to change anything?

Well I mean you can change it quite easily git commit --amend, force-push. Change it, say, to the same as what the PR title now is.

doc: Added hyperlink for doc/build 67c85bdb2f

Pradumnasaraf commented at 2:26 PM on September 9, 2021: contributor

@laanwj I feel it's ok now.🤞

DrahtBot removed the label Needs rebase on Sep 9, 2021

Pradumnasaraf commented at 8:52 AM on September 10, 2021: contributor

@MarcoFalke @laanwj , Look like all the checks have been passed, now we can merge?

MarcoFalke merged this on Sep 10, 2021

MarcoFalke closed this on Sep 10, 2021

sidhujag referenced this in commit 591b2c3fc8 on Sep 11, 2021

DrahtBot locked this on Oct 30, 2022