Filter listaddressgroupings #2291

pull mb300sd wants to merge 2 commits into bitcoin:master from mb300sd:filteraddrgroups changing 2 files +27 −10

mb300sd commented at 11:05 PM on February 9, 2013: contributor
My old patch for coin control converted to a pull.
- Added ability to filter empty groups and empty address from listaddressgroupings output.
- Output an object that's easier to work with than an array of different types.
BitcoinPullTester commented at 11:33 PM on February 9, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d9ab371f837476f863ca5c7a96e52f7f052f8246 for binaries and test log.
add filters to listaddressgroupings, output object 1bc879be95
jgarzik commented at 7:01 PM on June 19, 2013: contributor

Your output is superior to the existing output. However, I am forced to NAK because it breaks the existing API.

Given the lack of interest in this pull request, inclined to close for lack of interest plus API issue.
luke-jr commented at 8:38 PM on July 16, 2013: member

@jgarzik How does this break the existing API? From a readover, it seems to behave the same when called without options...?
luke-jr commented at 3:48 AM on July 17, 2013: member

@mb300sd BTW, this needs a rebase.
Merge branch 'master' into filteraddrgroups
Conflicts: src/bitcoinrpc.cpp src/rpcwallet.cpp
4c4c4d7904
BitcoinPullTester commented at 5:40 AM on October 7, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4c4c4d79046cc6523fcfa300485146a2bfead319 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gavinandresen commented at 1:24 AM on October 21, 2013: contributor
NACK: jgarzik is correct, this changes the RPC API, which is unacceptable:

Output of listaddressgroupings before:
```
    [
        [
            "miD5tprKXUrU97H5fK7pKfwyTH9aDgi5vd",
            50.00070000
        ]
    ]
```
After:
```
    [
        {
            "address" : "miD5tprKXUrU97H5fK7pKfwyTH9aDgi5vd",
            "balance" : 50.00070000
        }
    ]
```
Closing. Please open a new pull request if you come up with a backwards-compatible solution.
gavinandresen closed this on Oct 21, 2013
DrahtBot locked this on Sep 8, 2021
DrahtBot added the label CI failed on Apr 11, 2023
MarcoFalke removed the label CI failed on Apr 11, 2023

Contributors