build: Copy appropriate MSVC build output to src/qt automatically #22917

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210908-copy changing 3 files +14 −0

hebasto commented at 10:26 AM on September 8, 2021: member

This functionality is already present for non-qt output since #16308, and it was skipped to add in #15529.

Not finding bitcoin-qt.exe and test_bitcoin-qt.exe in the src\qt\ folder could confuse users.

This PR fixes that issue in the same way like #16308 did.
build: Copy appropriate MSVC build output to src/qt automatically
This functionality is already present for non-qt output since #16308.
4edc3db558
hebasto commented at 10:27 AM on September 8, 2021: member

cc @sipsorcery @MarcoFalke @NicolasDorier
DrahtBot added the label Build system on Sep 8, 2021
in build_msvc/common.qt.vcxproj:12 in 4edc3db558
```
   7 | +      <BuildArtifacts Include="$(OutDir)$(TargetName).pdb" Condition="Exists('$(OutDir)$(TargetName).pdb')"></BuildArtifacts>
   8 | +    </ItemGroup>
   9 | +    <Copy SourceFiles="@(BuildArtifacts)" SkipUnchangedFiles="true" DestinationFolder="..\..\src\qt\" Condition="'$(OutDir)' != ''"></Copy>
  10 | +  </Target>
  11 | +  <Import Project="common.qt.vcxproj.user" Condition="Exists('common.qt.vcxproj.user')" />
  12 | +</Project>
```
sipsorcery commented at 6:32 PM on September 8, 2021:

Do the Qt exe's need to be copied to src\qt for any paricular reason? Is that where the test scripts look for them? I believe Nicolas originally added the common.vcxproj config to copy the exe's to the src directory for conveniece. Perhaps it's sufficient here as well and avoids the need for the new common.qt.vcxproj file?

hebasto commented at 7:08 PM on September 8, 2021:

No test script uses bitcoin-qt.exe. The only reason is my confusion:

Not finding bitcoin-qt.exe ... in the src\qt\ folder could confuse users.

Probably, it is just my biased personal opinion.

sipsorcery commented at 7:11 PM on September 8, 2021:

If the test scripts don't need it in src\qt then I would recommend just including common.vcxproj and not bothering with the new common.qt.vcxproj file. Windows devs will normally look in the default output directory of build_msvc\x64\Release directory.

hebasto commented at 7:42 PM on September 8, 2021:

Windows devs will normally look in the default output directory of build_msvc\x64\Release directory.

Agree. Going to close this.
hebasto closed this on Sep 8, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

hebasto

sipsorcery

Labels

Build system

Linked (view graph)

#15529 Add Qt programs to msvc build (updated, no code changes)#16308 [MSVC] Copy build output to src/ automatically after build