The PYTHONUTF8 environment variable is defined in PEP 540, and it is actually used in our CI: https://github.com/bitcoin/bitcoin/blob/5e3380b9f59481fc18e05b9d651c3c733abe4053/.cirrus.yml#L89
This PR documents such usage to avoid users' errors.
doc: Set PYTHONUTF8=1 for functional tests on Windows #22926
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210908-utf changing 1 files +8 −1-
hebasto commented at 9:23 PM on September 8, 2021: member
-
doc: Set PYTHONUTF8=1 for functional tests on Windows c427a5800b
- DrahtBot added the label Docs on Sep 8, 2021
- DrahtBot added the label Tests on Sep 8, 2021
-
MarcoFalke commented at 6:25 AM on September 9, 2021: member
cr ACK c427a5800bb53208d30eeb03a73ab8be879e5f45
-
laanwj commented at 11:05 AM on September 9, 2021: member
I'm kind of surprised that we need it, because we jumped through quite some hoops to force UTF-8 everywhere (e.g. even adding
encoding='utf-8'toopencalls explicitly). But yes if we use it in CI it should be documented. -
MarcoFalke commented at 11:13 AM on September 9, 2021: member
From what I understand is that Windows is one of the few that doesn't use Unicode locale by default. According to the PEP, this can be enforced on the python side:
"use the utf-8 encoding, regardless of the locale currently set by the current platform, and"
-
laanwj commented at 11:19 AM on September 9, 2021: member
Right, this is really the sledgehammer option. I was hoping we didn't need it because we overrode all the specific occurrences where there was a doubt about character set. But apparently not, so we need it.
- fanquake merged this on Sep 10, 2021
- fanquake closed this on Sep 10, 2021
- hebasto deleted the branch on Sep 10, 2021
- sidhujag referenced this in commit 1d13b0f3b2 on Sep 11, 2021
- PastaPastaPasta referenced this in commit bb1b6635e0 on Mar 13, 2022
- DrahtBot locked this on Oct 30, 2022
Contributors