doc: Remove stale comment for CPrivKey #22995

pull kcalvinalvin wants to merge 1 commits into bitcoin:master from kcalvinalvin:update-stale-allocator-comment changing 1 files +0 −1

kcalvinalvin commented at 11:12 AM on September 16, 2021: contributor

Removes stale doc about secure_allocator being defined in allocators.h.
fanquake added the label Docs on Sep 16, 2021
doc: Remove stale comment for CPrivKey 5008dd87b2
in src/key.h:20 in 09203bbef2 outdated
```
  16 | @@ -17,7 +17,7 @@
  17 |  
  18 |  
  19 |  /**
  20 | - * secure_allocator is defined in allocators.h
  21 | + * secure_allocator is defined in allocators/secure.h
```
laanwj commented at 12:06 PM on September 16, 2021:

Good catch. I'd, personally, prefer removing this line completely. If you want to find out where it is defined, you can find it. (e.g. through doxygen, IDE functionality, grep … no need for hand holding here)

kcalvinalvin commented at 12:18 PM on September 16, 2021:

Fixed
kcalvinalvin force-pushed on Sep 16, 2021
kcalvinalvin renamed this:
~~doc: Update stale comment about secure allocators.~~
doc: Remove stale comment for CPrivKey
on Sep 16, 2021
laanwj commented at 12:27 PM on September 16, 2021: member

Thanks! ACK 5008dd87b2c9a8eeee21f2a11367a7ada9c324ed
theStack approved
theStack commented at 12:58 PM on September 16, 2021: member

Agree that this line is not needed.

Code-review ACK 5008dd87b2c9a8eeee21f2a11367a7ada9c324ed
laanwj referenced this in commit 7a999879d2 on Sep 16, 2021
MarcoFalke closed this on Sep 16, 2021
kcalvinalvin deleted the branch on Sep 16, 2021
fanquake locked this on Sep 18, 2021

Contributors

Labels