Unused includes will cause needless recompilation when headers are changed. Also, they pretend there are dependencies that don't exist.
Fix both by removing them.
refactor: Remove unused validation includes #23044
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2109-valInc changing 3 files +3 −12-
MarcoFalke commented at 10:18 AM on September 20, 2021: member
-
refactor: Remove unused validation includes fa45a1338a
-
MarcoFalke commented at 10:20 AM on September 20, 2021: member
Done after #22626#pullrequestreview-745479829
- fanquake added the label Refactoring on Sep 20, 2021
-
laanwj commented at 12:41 PM on September 20, 2021: member
Code review ACK fa45a1338adb127d69aee982920e29519bc1fed6
-
DrahtBot commented at 5:21 AM on September 21, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22951 (consensus: move amount.h into consensus by fanquake)
- #10443 (Add fee_est tool for debugging fee estimation code by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- theStack approved
-
theStack commented at 10:34 AM on September 22, 2021: member
ACK fa45a1338adb127d69aee982920e29519bc1fed6 ♻️
- MarcoFalke merged this on Sep 22, 2021
- MarcoFalke closed this on Sep 22, 2021
- MarcoFalke deleted the branch on Sep 22, 2021
- sidhujag referenced this in commit 3f7b0cd268 on Sep 22, 2021
- DrahtBot locked this on Oct 30, 2022
Contributors
Labels