test: Use MiniWallet in mempool_persist #23047

pull MarcoFalke wants to merge 5 commits into bitcoin:master from MarcoFalke:2109-testMempool changing 2 files +42 −25

MarcoFalke commented at 1:50 PM on September 20, 2021: member

No description provided.
test: Add MiniWallet get_descriptor function faca688a85
test: Use MiniWallet in mempool_persist fa32cb2467
test: pep8 fafb7b7a89

test: Remove unused self.connect_nodes

The nodes are stopped in the next line, no need to connect them

fa4db92617

test: Check other fields are loaded correctly as well faae0988d6
fanquake added the label Tests on Sep 20, 2021
DrahtBot commented at 5:07 AM on September 21, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #22567 (test: Implicitly sync after generate* to preempt races and intermittent test failures by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in test/functional/mempool_persist.py:138 in faae0988d6

 139 |  
 140 | -        # start node0 with wallet disabled so wallet transactions don't get resubmitted
 141 |          self.log.debug("Stop-start node0 with -persistmempool=0. Verify that it doesn't load its mempool.dat file.")
 142 |          self.stop_nodes()
 143 | -        self.start_node(0, extra_args=["-persistmempool=0", "-disablewallet"])
 144 | +        self.start_node(0, extra_args=["-persistmempool=0"])

Shubhankar-Gambhir commented at 8:50 AM on September 22, 2021:

shouldn't node be started with disabled wallet?

Shubhankar-Gambhir commented at 8:59 AM on September 22, 2021:

Feel free to ignore this but you can use self.restart_node() here.

MarcoFalke commented at 9:06 AM on September 22, 2021:

No wallet (that has any unconfirmed txs) should exist for node 0

laanwj commented at 2:38 PM on September 24, 2021: member

Code review ACK faae0988d6abb50039026a49543eef134eb9103f
laanwj merged this on Sep 24, 2021
laanwj closed this on Sep 24, 2021
sidhujag referenced this in commit 5e65cb22f0 on Sep 24, 2021
sidhujag referenced this in commit 67b132d520 on Sep 24, 2021
MarcoFalke deleted the branch on Sep 27, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels

test: Use MiniWallet in mempool_persist #23047

Conflicts