Logging of Callbacks are no longer needed and records times that are not relevant for performance analysis. resolves #23071
log: Remove unnecessary timing of Callbacks bench #23072
pull dougEfresh wants to merge 1 commits into bitcoin:master from dougEfresh:23071_remove_callback_bench changing 1 files +0 −4-
dougEfresh commented at 8:50 AM on September 23, 2021: contributor
- fanquake added the label Validation on Sep 23, 2021
- dougEfresh force-pushed on Sep 23, 2021
-
laanwj commented at 11:16 AM on September 23, 2021: member
Code review ACK f6f0d789c52dbb1d3a447a3b7e315249a2a292ce
I would suggest calling it something else than a 'refactor' in the commit and PR description as it intentionally changes the functionality of the code.
-
ab27800799
log: Remove unnecessary timing logs for Callbacks bench
Logging of Callbacks are no longer needed and records events that are not relevant for performance analysis.
- dougEfresh force-pushed on Sep 23, 2021
- dougEfresh renamed this:
refactor: Remove unnecessary timing of Callbacks bench
log: Remove unnecessary timing of Callbacks bench
on Sep 23, 2021 -
dougEfresh commented at 11:40 AM on September 23, 2021: contributor
Code review ACK f6f0d78
I would suggest calling it something else than a 'refactor' in the commit and PR description as it intentionally changes the functionality of the code.
Now PR and commit use the keyword
log -
laanwj commented at 12:17 PM on September 23, 2021: member
Thanks. re-ACK ab278007991b912299eaf794d87a636423521d27
-
jonatack commented at 1:03 PM on September 23, 2021: member
Code review ACK ab278007991b912299eaf794d87a636423521d27
- MarcoFalke merged this on Sep 23, 2021
- MarcoFalke closed this on Sep 23, 2021
- sidhujag referenced this in commit def0c83ccf on Sep 24, 2021
- dougEfresh deleted the branch on Sep 26, 2021
- Fabcien referenced this in commit 9e46755c69 on Oct 17, 2022
- DrahtBot locked this on Oct 30, 2022
Contributors
Labels