If signing a PSBT, we need to ensure the wallet is unlocked.
Fixes #22874, fixes bitcoin-core/gui#312
Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI #23106
pull meshcollider wants to merge 3 commits into bitcoin:master from meshcollider:202109_walletprocesspsbt_unlocked changing 3 files +20 −2-
meshcollider commented at 12:31 PM on September 27, 2021: contributor
-
Ensure wallet is unlocked before signing in walletprocesspsbt 0e895212bb
- meshcollider added the label Wallet on Sep 27, 2021
-
ghost commented at 12:47 PM on September 27, 2021: none
Related GUI issue: https://github.com/bitcoin-core/gui/issues/312
-
promag commented at 1:13 PM on September 27, 2021: member
Concept ACK. Could include a test.
-
DrahtBot commented at 2:59 PM on September 27, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22513 (rpc: Allow walletprocesspsbt to sign without finalizing by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
meshcollider commented at 11:41 PM on September 27, 2021: contributor
Sure, added a test
-
meshcollider commented at 12:09 AM on September 28, 2021: contributor
Added another commit to address the GUI issue @prayank23 mentioned.
-
Add test that walletprocesspsbt requires unlocked wallet when signing 0f3acecf33
-
GUI: Ask user to unlock wallet before signing psbt 7e3ee4cdd0
- meshcollider renamed this:
Ensure wallet is unlocked before signing in walletprocesspsbt
Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI
on Sep 28, 2021 - meshcollider added the label GUI on Sep 28, 2021
- meshcollider added the label RPC/REST/ZMQ on Sep 28, 2021
-
achow101 commented at 3:12 AM on September 28, 2021: member
ACK 7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5
- lsilva01 approved
-
lsilva01 commented at 3:22 AM on September 28, 2021: contributor
- benthecarman approved
-
benthecarman commented at 7:25 AM on September 28, 2021: contributor
ACK 7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5
- MarcoFalke merged this on Sep 28, 2021
- MarcoFalke closed this on Sep 28, 2021
-
ghost commented at 8:18 AM on September 28, 2021: none
Post merge tACK https://github.com/bitcoin/bitcoin/commit/7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5
<details> <summary>GUI</summary>
</details>
<details> <summary>CLI </summary>
$ bitcoin-cli walletprocesspsbt cHNidP8BAHECAAAAAc8rxxALBsWEEOQeiG8omNLS4etwfelczxCNkXq9ZkeDAQAAAAD9////AsPCAAAAAAAAFgAUk+E508Evzkjtp96eDMvj9acJsflQwwAAAAAAABYAFHRCFAkrwLrC4N8FwoQe83iHlPkZJP4fAAABAPUCAAAAAAEBn+1tNePIJterqM3FTCHyU5Pd7gDINjeWro57Og5DJmEAAAAAFxYAFMfPZFdLtGL2sDk+VtPq+FwO82Bv/v///wJYfwwBAAAAABYAFFKue/4Z1wdWSuWrItUf3XESDfiyoIYBAAAAAAAWABST4TnTwS/OSO2n3p4My+P1pwmx+QJHMEQCID4Hj3fkUhjkkGlJmmFqxkzjd7aN6Jc3RwSEc/kZ+ipFAiAq0iVNaVehtVFMIde58WjA0oyzMl1TNIAnWD7eqEh/gwEhA39z5OpBbgNSPWgXtFdiJiKMFrvE20Z9vHiXe5BERwWJ9P0fAAAAAA== Error: Please enter the wallet passphrase with walletpassphrase first. (code -13)</details>
-
promag commented at 10:49 AM on September 28, 2021: member
Code review ACK 7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5.
- sidhujag referenced this in commit 64585354c6 on Sep 28, 2021
- luke-jr referenced this in commit f70d62341f on Oct 10, 2021
- luke-jr referenced this in commit 05d1bc0a6a on Oct 10, 2021
- luke-jr referenced this in commit aebd7bceaf on Oct 10, 2021
- luke-jr referenced this in commit 09895417fa on Dec 14, 2021
- luke-jr referenced this in commit 55fe90cefb on Dec 14, 2021
- luke-jr referenced this in commit 1dc7d2622a on Dec 14, 2021
- DrahtBot locked this on Oct 30, 2022
