Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI #23106

1. 
   meshcollider commented at 12:31 pm on September 27, 2021: contributor

   If signing a PSBT, we need to ensure the wallet is unlocked.

   Fixes #22874, fixes bitcoin-core/gui#312

2. Ensure wallet is unlocked before signing in walletprocesspsbt 0e895212bb
3. meshcollider added the label Wallet on Sep 27, 2021
4. 
   ghost commented at 12:47 pm on September 27, 2021: none

   Related GUI issue: https://github.com/bitcoin-core/gui/issues/312
5. 
   promag commented at 1:13 pm on September 27, 2021: member

   Concept ACK. Could include a test.
6. 
   DrahtBot commented at 2:59 pm on September 27, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #22513 (rpc: Allow walletprocesspsbt to sign without finalizing by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   meshcollider commented at 11:41 pm on September 27, 2021: contributor

   Sure, added a test
8. 
   meshcollider commented at 0:09 am on September 28, 2021: contributor

   Added another commit to address the GUI issue @prayank23 mentioned.
9. Add test that walletprocesspsbt requires unlocked wallet when signing 0f3acecf33
10. GUI: Ask user to unlock wallet before signing psbt 7e3ee4cdd0
11. meshcollider renamed this:
    Ensure wallet is unlocked before signing in walletprocesspsbt
    Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI
    on Sep 28, 2021
12. meshcollider added the label GUI on Sep 28, 2021
13. meshcollider added the label RPC/REST/ZMQ on Sep 28, 2021
14. 
    achow101 commented at 3:12 am on September 28, 2021: member

    ACK 7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5
15. lsilva01 approved
16. 
    lsilva01 commented at 3:22 am on September 28, 2021: contributor

    Code Review ACK https://github.com/bitcoin/bitcoin/pull/23106/commits/7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5
17. benthecarman approved
18. 
    benthecarman commented at 7:25 am on September 28, 2021: contributor

    ACK 7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5
19. MarcoFalke merged this on Sep 28, 2021
20. MarcoFalke closed this on Sep 28, 2021

    ---

21. 
    ghost commented at 8:18 am on September 28, 2021: none

    Post merge tACK https://github.com/bitcoin/bitcoin/commit/7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5

    

    

    0$ bitcoin-cli walletprocesspsbt cHNidP8BAHECAAAAAc8rxxALBsWEEOQeiG8omNLS4etwfelczxCNkXq9ZkeDAQAAAAD9////AsPCAAAAAAAAFgAUk+E508Evzkjtp96eDMvj9acJsflQwwAAAAAAABYAFHRCFAkrwLrC4N8FwoQe83iHlPkZJP4fAAABAPUCAAAAAAEBn+1tNePIJterqM3FTCHyU5Pd7gDINjeWro57Og5DJmEAAAAAFxYAFMfPZFdLtGL2sDk+VtPq+FwO82Bv/v///wJYfwwBAAAAABYAFFKue/4Z1wdWSuWrItUf3XESDfiyoIYBAAAAAAAWABST4TnTwS/OSO2n3p4My+P1pwmx+QJHMEQCID4Hj3fkUhjkkGlJmmFqxkzjd7aN6Jc3RwSEc/kZ+ipFAiAq0iVNaVehtVFMIde58WjA0oyzMl1TNIAnWD7eqEh/gwEhA39z5OpBbgNSPWgXtFdiJiKMFrvE20Z9vHiXe5BERwWJ9P0fAAAAAA==
    1
    2Error: Please enter the wallet passphrase with walletpassphrase first. (code -13)
    

22. 
    promag commented at 10:49 am on September 28, 2021: member

    Code review ACK 7e3ee4cdd0f60a2f549ba030fe96b90d61c036c5.
23. sidhujag referenced this in commit 64585354c6 on Sep 28, 2021
24. luke-jr referenced this in commit f70d62341f on Oct 10, 2021
25. luke-jr referenced this in commit 05d1bc0a6a on Oct 10, 2021
26. luke-jr referenced this in commit aebd7bceaf on Oct 10, 2021
27. luke-jr referenced this in commit 09895417fa on Dec 14, 2021
28. luke-jr referenced this in commit 55fe90cefb on Dec 14, 2021
29. luke-jr referenced this in commit 1dc7d2622a on Dec 14, 2021
30. DrahtBot locked this on Oct 30, 2022

Contributors
meshcollider ghost promag DrahtBot achow101 lsilva01 benthecarman

Labels
GUI Wallet RPC/REST/ZMQ