qa: Intermittent failure in `feature_segwit.py --legacy-wallet`

hebasto commented at 8:17 am on September 28, 2021: member

On master (a8bbd4cc819633ec50ed0f763b6a75330ae055fb), native Windows build:

 08/219 - feature_segwit.py --legacy-wallet failed, Duration: 17 s
 1stdout:
 22021-09-28T08:10:35.808000Z TestFramework (INFO): Initializing test directory C:\Users\ContainerAdministrator\AppData\Local\Temp\test_runner_₿_🏃_20210928_080804\feature_segwit_208
 32021-09-28T08:10:39.302000Z TestFramework (INFO): Verify sigops are counted in GBT with pre-BIP141 rules before the fork
 42021-09-28T08:10:49.277000Z TestFramework (INFO): Verify witness txs are skipped for mining before the fork
 52021-09-28T08:10:50.441000Z TestFramework (INFO): Verify unsigned p2sh witness txs without a redeem script are invalid
 62021-09-28T08:10:50.488000Z TestFramework (INFO): Verify previous witness txs skipped for mining can now be mined
 72021-09-28T08:10:50.535000Z TestFramework (INFO): Verify default node can't accept txs with missing witness
 82021-09-28T08:10:50.581000Z TestFramework (INFO): Verify block and transaction serialization rpcs return differing serializations depending on rpc serialization flag
 92021-09-28T08:10:50.738000Z TestFramework (INFO): Verify witness txs without witness data are invalid after the fork
102021-09-28T08:10:50.769000Z TestFramework (INFO): Verify default node can now use witness txs
112021-09-28T08:10:50.960000Z TestFramework (INFO): Verify sigops are counted in GBT with BIP141 rules after the fork
122021-09-28T08:10:51.971000Z TestFramework (ERROR): Assertion failed
13Traceback (most recent call last):
14  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 131, in main
15    self.run_test()
16  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_segwit.py", line 239, in run_test
17    assert tmpl['transactions'][0]['sigops'] == 8
18AssertionError

hebasto added the label Bug on Sep 28, 2021

hebasto added the label Tests on Sep 28, 2021

MarcoFalke commented at 8:39 am on September 28, 2021: member

Would be nice to use assert_equal, so that the wrong value is printed the next time this fails

MarcoFalke commented at 11:19 am on September 28, 2021: member

Same on a non-Windows task: https://cirrus-ci.com/task/4714184320483328?logs=ci#L3458

fanquake referenced this in commit dccf3d25f9 on Sep 28, 2021

hebasto commented at 12:52 pm on September 28, 2021: member

With assert_equal https://api.cirrus-ci.com/v1/task/4880559223603200/logs/functional_tests.log:

 09/219 - feature_segwit.py --legacy-wallet failed, Duration: 18 s
 1stdout:
 22021-09-28T12:44:47.048000Z TestFramework (INFO): Initializing test directory C:\Users\ContainerAdministrator\AppData\Local\Temp\test_runner_₿_🏃_20210928_124215\feature_segwit_208
 32021-09-28T12:44:51.331000Z TestFramework (INFO): Verify sigops are counted in GBT with pre-BIP141 rules before the fork
 42021-09-28T12:45:00.525000Z TestFramework (INFO): Verify witness txs are skipped for mining before the fork
 52021-09-28T12:45:01.751000Z TestFramework (INFO): Verify unsigned p2sh witness txs without a redeem script are invalid
 62021-09-28T12:45:01.797000Z TestFramework (INFO): Verify previous witness txs skipped for mining can now be mined
 72021-09-28T12:45:02.861000Z TestFramework (INFO): Verify default node can't accept txs with missing witness
 82021-09-28T12:45:02.908000Z TestFramework (INFO): Verify block and transaction serialization rpcs return differing serializations depending on rpc serialization flag
 92021-09-28T12:45:03.080000Z TestFramework (INFO): Verify witness txs without witness data are invalid after the fork
102021-09-28T12:45:03.126000Z TestFramework (INFO): Verify default node can now use witness txs
112021-09-28T12:45:03.298000Z TestFramework (INFO): Verify sigops are counted in GBT with BIP141 rules after the fork
122021-09-28T12:45:04.126000Z TestFramework (ERROR): Assertion failed
13Traceback (most recent call last):
14  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 131, in main
15    self.run_test()
16  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_segwit.py", line 244, in run_test
17    assert_equal(tmpl['transactions'][0]['sigops'], 8)
18  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\util.py", line 49, in assert_equal
19    raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
20AssertionError: not(9 == 8)

meshcollider commented at 4:14 am on September 29, 2021: contributor

Managed to get some more output locally using a few extra log commands:

 02021-09-29T04:12:35.828000Z TestFramework (INFO): [RAWTX]:
 12021-09-29T04:12:35.829000Z TestFramework (INFO): {'txid': '437738c723bef814efaa4ea6c1d75abad7c5a46581193ee45752206458bdd5ae', 'hash': '42fdc6f5599720870fc0dc4c7afcaa39bbd568b1b1c6485cacc5880443b58eff', 'version': 2, 'size': 268, 'vsize': 183, 'weight': 730, 'locktime': 436, 'vin': [{'txid': 'd383c5ede4a367911c11614c51f462f78a66efe16755410dc0e318e534ddf3a4', 'vout': 0, 'scriptSig': {'asm': '0020366c4902213bcdb36c442b74b4de819ab4afb7ffdf40764d4e7f9eb9aa1c6e4f', 'hex': '220020366c4902213bcdb36c442b74b4de819ab4afb7ffdf40764d4e7f9eb9aa1c6e4f'}, 'txinwitness': ['', '30440220085d600265bb5bd8b5dcb37dccf0bdcb5a17cb557f7915c5a6bbfd6fc92f25ee022054938052d9252314f81f5c5e87d3c6a71f290a0e0f605a2c3b8fbb664ebb295401', '5121039e8d8e9d1b2510cef293407a8de9183cabcb15ec694344b9a826a56c5dde400551ae'], 'sequence': 4294967294}], 'vout': [{'value': Decimal('48.99896340'), 'n': 0, 'scriptPubKey': {'asm': 'OP_DUP OP_HASH160 31695740fef5116954ddad139a9c9e1c6dc530e4 OP_EQUALVERIFY OP_CHECKSIG', 'hex': '76a91431695740fef5116954ddad139a9c9e1c6dc530e488ac', 'address': 'mk2DbfRWzFEuyXnpuDvHKyjGTTcCUitPJZ', 'type': 'pubkeyhash'}}, {'value': Decimal('1.00000000'), 'n': 1, 'scriptPubKey': {'asm': 'OP_DUP OP_HASH160 96538a8277e4ef9403ad33bb4191f88e95c08475 OP_EQUALVERIFY OP_CHECKSIG', 'hex': '76a91496538a8277e4ef9403ad33bb4191f88e95c0847588ac', 'address': 'muDojMzU1fg6DEVWFPRJxbU4g8LFgVVz1o', 'type': 'pubkeyhash'}}], 'hex': '0200000001a4f3dd34e518e3c00d415567e1ef668af762f4514c61111c9167a3e4edc583d30000000023220020366c4902213bcdb36c442b74b4de819ab4afb7ffdf40764d4e7f9eb9aa1c6e4ffeffffff02147c0e24010000001976a91431695740fef5116954ddad139a9c9e1c6dc530e488ac00e1f505000000001976a91496538a8277e4ef9403ad33bb4191f88e95c0847588acb4010000'}
 22021-09-29T04:12:35.831000Z TestFramework (INFO): [TEMPLATE]:
 32021-09-29T04:12:35.831000Z TestFramework (INFO): {'capabilities': ['proposal'], 'version': 536870912, 'rules': ['csv', '!segwit', 'testdummy', 'taproot'], 'vbavailable': {}, 'vbrequired': 0, 'previousblockhash': '1f50adae7f37543549ffe6e22f236eceb33355c06f23699d6c6bc0002b590e83', 'transactions': [{'data': '02000000000101a4f3dd34e518e3c00d415567e1ef668af762f4514c61111c9167a3e4edc583d30000000023220020366c4902213bcdb36c442b74b4de819ab4afb7ffdf40764d4e7f9eb9aa1c6e4ffeffffff02147c0e24010000001976a91431695740fef5116954ddad139a9c9e1c6dc530e488ac00e1f505000000001976a91496538a8277e4ef9403ad33bb4191f88e95c0847588ac03004730440220085d600265bb5bd8b5dcb37dccf0bdcb5a17cb557f7915c5a6bbfd6fc92f25ee022054938052d9252314f81f5c5e87d3c6a71f290a0e0f605a2c3b8fbb664ebb295401255121039e8d8e9d1b2510cef293407a8de9183cabcb15ec694344b9a826a56c5dde400551aeb4010000', 'txid': '437738c723bef814efaa4ea6c1d75abad7c5a46581193ee45752206458bdd5ae', 'hash': '42fdc6f5599720870fc0dc4c7afcaa39bbd568b1b1c6485cacc5880443b58eff', 'depends': [], 'fee': 3660, 'sigops': 9, 'weight': 730}], 'coinbaseaux': {}, 'coinbasevalue': 1250003660, 'longpollid': '1f50adae7f37543549ffe6e22f236eceb33355c06f23699d6c6bc0002b590e83570', 'target': '7fffff0000000000000000000000000000000000000000000000000000000000', 'mintime': 1632888824, 'mutable': ['time', 'transactions', 'prevblock'], 'noncerange': '00000000ffffffff', 'sigoplimit': 80000, 'sizelimit': 4000000, 'weightlimit': 4000000, 'curtime': 1632888824, 'bits': '207fffff', 'height': 437, 'default_witness_commitment': '6a24aa21a9ed2d0140b70952200db4620b5477ef45815e135c1f432f8323d34ee989ea47393b'}
 42021-09-29T04:12:35.831000Z TestFramework (INFO): [TX]:
 52021-09-29T04:12:35.831000Z TestFramework (INFO): 437738c723bef814efaa4ea6c1d75abad7c5a46581193ee45752206458bdd5ae
 62021-09-29T04:12:35.831000Z TestFramework (ERROR): Assertion failed
 7Traceback (most recent call last):
 8  File "/Users/sdob814/git/bitcoin/test/functional/test_framework/test_framework.py", line 131, in main
 9    self.run_test()
10  File "./test/functional/feature_segwit.py", line 251, in run_test
11    assert_equal(tmpl['transactions'][0]['sigops'], 8)
12  File "/Users/sdob814/git/bitcoin/test/functional/test_framework/util.py", line 49, in assert_equal
13    raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
14AssertionError: not(9 == 8)

MarcoFalke referenced this in commit d648bbb0a7 on Sep 29, 2021

MarcoFalke closed this on Sep 29, 2021

sidhujag referenced this in commit f8664d5b7e on Sep 29, 2021

DrahtBot locked this on Oct 30, 2022

qa: Intermittent failure in feature_segwit.py --legacy-wallet #23116

qa: Intermittent failure in `feature_segwit.py --legacy-wallet` #23116