test: Use assert_equal over assert for easier debugging #23117

1. 
   MarcoFalke commented at 8:43 am on September 28, 2021: member

   See #23116
2. test: Use assert_equal over assert for easier debugging fac5708afc
3. test: pep-8 fa8f3ba131
4. MarcoFalke force-pushed on Sep 28, 2021
5. 
   jonatack commented at 9:00 am on September 28, 2021: member

   Light code review ACK fa8f3ba131d5460275b52c08608ebad8195a420d
6. hebasto approved
7. 
   hebasto commented at 9:24 am on September 28, 2021: member

   ACK fa8f3ba131d5460275b52c08608ebad8195a420d, I have reviewed the code and it looks OK, I agree it can be merged.
8. DrahtBot added the label Tests on Sep 28, 2021
9. theStack approved
10. 
    theStack commented at 12:13 pm on September 28, 2021: member

    Code-review ACK fa8f3ba131d5460275b52c08608ebad8195a420d

    Note that there are dozens of other instances in the functional test code where this substitution should be done:

    0$ cd ./test/functional
    1$ git grep assert.*== | wc -l
    2      153
    

    (though this number contains obviously also some false-positives)

11. fanquake merged this on Sep 28, 2021
12. fanquake closed this on Sep 28, 2021

    ---

13. MarcoFalke deleted the branch on Sep 28, 2021
14. 
    MarcoFalke commented at 12:28 pm on September 28, 2021: member

    (though this number contains obviously also some false-positives)

    Could be filed as a good first issue?

15. sidhujag referenced this in commit 38575c90dc on Sep 28, 2021
16. DrahtBot locked this on Oct 30, 2022

Contributors
MarcoFalke jonatack hebasto theStack

Labels
Tests