wallet: fund transaction external input cleanups #23188

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:fundtx-external-inputs_cleanups changing 3 files +6 −6

instagibbs commented at 1:39 PM on October 5, 2021: member

Minor cleanups to https://github.com/bitcoin/bitcoin/pull/17211
fanquake added the label Wallet on Oct 5, 2021
achow101 commented at 5:53 PM on October 5, 2021: member

ACK 7d56d5a77fc7ee9095deb36b8e05f8969461c533
meshcollider commented at 10:05 PM on October 5, 2021: contributor

~Perhaps you could also include a fix to the intermittent test failure?~ I'll open a PR

Also please squash, they're all trivial 2 line commits.

External input fund support cleanups

Synchronize error checking for external inputs
Rename external output Select to SelectExternal
Const FundTransaction variables

43568782c2

instagibbs force-pushed on Oct 5, 2021
instagibbs commented at 10:57 PM on October 5, 2021: member

@meshcollider thanks, I couldn't figure out how many test issues there were in total. Please tag me in the PR for review

squashed
achow101 commented at 11:19 PM on October 5, 2021: member

ACK 43568782c23185a0599a6e60d61db4716da1cda1
meshcollider commented at 11:22 PM on October 5, 2021: contributor

utACK 43568782c23185a0599a6e60d61db4716da1cda1
MarcoFalke added the label Refactoring on Oct 6, 2021
MarcoFalke commented at 8:50 AM on October 6, 2021: member

Is this "cleanup" a refactoring or a behaviour change?
instagibbs commented at 8:52 AM on October 6, 2021: member

Should be non behavior changing.

On Wed, Oct 6, 2021, 4:50 PM MarcoFalke @.***> wrote:

Is this "cleanup" a refactoring or a behaviour change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/23188#issuecomment-935774129, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMAFU6UIZT3F4QSE76RKFTUFQEVBANCNFSM5FL2FXZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
DrahtBot commented at 11:52 AM on October 6, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #22019 (wallet: Introduce SelectionResult for encapsulating a coin selection solution by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
benthecarman approved
benthecarman commented at 10:21 PM on October 7, 2021: contributor

ACK 43568782c23185a0599a6e60d61db4716da1cda1
fanquake merged this on Oct 8, 2021
fanquake closed this on Oct 8, 2021
sidhujag referenced this in commit f5d10fe4ca on Oct 8, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels

Linked (view graph)

#17211 Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs

wallet: fund transaction external input cleanups #23188

Conflicts