lint-whitespace assumes a branch "master" exists as a fallback for merge-base #23246

issue luke-jr opened this issue on October 10, 2021
  1. luke-jr commented at 5:15 PM on October 10, 2021: member

    If git merge-base HEAD master (line 30) fails (eg, due to no master branch in the repo), the linter fails too.

    I'm not sure what the ideal behaviour here is. Even if personal repos have a master branch, it's not necessarily going to be up to date.

    We could just gate this fallback on [ "$CIRRUS_REPO_FULL_NAME" = "bitcoin/bitcoin" ], but if there's a way to figure out the correct base, that would be better...

  2. luke-jr added the label Bug on Oct 10, 2021
  3. MarcoFalke commented at 6:43 AM on October 11, 2021: member

    I don't think this can be solved. If the base is missing or outdated, it won't be possible to figure it out.

    Also, a gate on bitcoin/bitcoin won't work because the config is used by bitcoin-core/gui and bitcoin-core/qml.

  4. MarcoFalke closed this on Aug 5, 2022

  5. MarcoFalke added the label Tests on Aug 5, 2022
  6. bitcoin locked this on Aug 5, 2023
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me