doc: Fix typo and grammar #23254

pull hieblmi wants to merge 1 commits into bitcoin:master from hieblmi:patch-1 changing 1 files +2 −2
  1. hieblmi commented at 12:26 PM on October 11, 2021: contributor

    Fix typo and grammar in the coin selection algorithm's description.

  2. Fix typo and grammar
    Fix typo and grammar in the coin selection algorithm's description.
    ffd11ea876
  3. fanquake added the label Docs on Oct 11, 2021
  4. MarcoFalke renamed this:
    Fix typo and grammar
    doc: Fix typo and grammar
    on Oct 11, 2021
  5. MarcoFalke added the label Wallet on Oct 11, 2021
  6. shaavan commented at 1:05 PM on October 12, 2021: contributor

    Concept ACK

    The PR corrects grammatical errors and typos in the coinselection.cpp file. The changes look good and improve the correctness of the sentence.

    I have some more suggestions that you might look at that will help make this PR even better. (The changes were made using Grammarly Premium)

    diff --git a/src/wallet/coinselection.cpp b/src/wallet/coinselection.cpp
    index c0ca93136..96505a356 100644
    --- a/src/wallet/coinselection.cpp
    +++ b/src/wallet/coinselection.cpp
    @@ -26,11 +26,11 @@ struct {
      * set that can pay for the spending target and does not exceed the spending target by more than the
      * cost of creating and spending a change output. The algorithm uses a depth-first search on a binary
      * tree. In the binary tree, each node corresponds to the inclusion or the omission of a UTXO. UTXOs
    - * are sorted by their effective values and the tree is explored deterministically per the inclusion
    + * are sorted by their effective values, and the tree is explored deterministically per the inclusion
      * branch first. At each node, the algorithm checks whether the selection is within the target range.
    
    - * While the selection has not reached the target range, more UTXOs are included. When a selection's
    - * value exceeds the target range, the complete subtree deriving from this selection can be omitted.
    - * At that point, the last included UTXO is deselected and the corresponding omission branch explored
    + * While the selection has not reached the target range, more UTXOs are included. The complete subtree
    + * deriving from this selection can be omitted when a selection's value exceeds the target range.
    + * At that point, the last included UTXO is deselected, and the corresponding omission branch is explored
      * instead. The search ends after the complete tree has been searched or after a limited number of tries.
      *
    
  7. meshcollider commented at 9:41 AM on December 8, 2021: contributor

    ACK ffd11ea87640c8a3d83b6f83ac18e65234fc6002

  8. meshcollider merged this on Dec 8, 2021
  9. meshcollider closed this on Dec 8, 2021

  10. sidhujag referenced this in commit 401c9992f0 on Dec 8, 2021
  11. RandyMcMillan referenced this in commit 419dfbaccb on Dec 23, 2021
  12. PastaPastaPasta referenced this in commit d086940c4c on Apr 7, 2022
  13. PastaPastaPasta referenced this in commit 6f6cfa0d8f on Apr 7, 2022
  14. PastaPastaPasta referenced this in commit 527a9d08a3 on Apr 7, 2022
  15. PastaPastaPasta referenced this in commit b1d3020568 on Apr 11, 2022
  16. DrahtBot locked this on Dec 8, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me