test: check that bumpfee RPC fails for txs with descendants in mempool #23281

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202110-test-bumpfee_test_descendant_in_mempool changing 1 files +10 −0

theStack commented at 12:57 AM on October 15, 2021: member

This PR adds missing test coverage for the bumpfee RPC error "Transaction has descendants in the mempool",

https://github.com/bitcoin/bitcoin/blob/6419bdfeb130b20ccfed229d9ba7eca7f385d036/src/wallet/feebumper.cpp#L29-L32

which is thrown if the bumped tx has descendants in the mempool and is not connected to the bitcoin wallet (for those, the error "Transaction has descendants in the Wallet" is thrown a few lines above). To achieve that, the test framework's MiniWallet is used.

test: check that bumpfee RPC fails for txs with descendants in mempool

This commit adds missing test coverage for the bumpfee RPC
error "Transaction has descendants in the mempool", which is
thrown if the bumped tx has descendants in the mempool and is
_not_ connected to the bitcoin wallet. To achieve that, the
test framework's MiniWallet is used.

4ac8c89ad9

fanquake added the label Tests on Oct 15, 2021
brunoerg approved
brunoerg commented at 7:32 PM on October 15, 2021: member

tACK 4ac8c89ad96de9ad61cad756b10c9dee2d9e1405
promag commented at 8:14 PM on October 15, 2021: member
Code review ACK 4ac8c89ad96de9ad61cad756b10c9dee2d9e1405. Nice stuff!

It looks like these are still untested:
- "Transaction has been mined, or is conflicted with a mined transaction"
- "Cannot bump transaction %s which was already bumped by transaction %s".
lsilva01 approved
lsilva01 commented at 4:42 AM on October 18, 2021: contributor

Tested ACK 4ac8c89 cad756b10c9dee2d9e1405 on Ubuntu 20.04.
stratospher commented at 3:09 PM on October 19, 2021: contributor

tested ACK 4ac8c89.
MarcoFalke merged this on Oct 21, 2021
MarcoFalke closed this on Oct 21, 2021
sidhujag referenced this in commit 56caee9b80 on Oct 21, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels