tests: reduce feature_segwit.py usage of the legacy wallet #23312

pull achow101 wants to merge 3 commits into bitcoin:master from achow101:refactor-feature-segwit changing 2 files +314 −282

achow101 commented at 10:45 PM on October 19, 2021: member

feature_segwit.py has tests for some legacy wallet behavior, but otherwise does not really need the legacy wallet. Those parts now require --legacy-wallet to be provided (as with other legacy wallet tests). Other parts of the test are changed to work with descriptor wallets as well.

tests: Use descriptors for feature_segwit multisig setup

When setting up the multisig addresses in feature_segwit.py, use
descriptors rather than addmultisigaddress.

1d13c44a4c

tests: restrict feature_segwit legacy wallet import tests

A portion of feature_segwit deals with the legacy wallet IsMine and
import behavior. This is now hidden behind --legacy-wallet

ae6cbcc909

tests: Add feature_segwit.py --descriptors to test_runner.py e9ade032f3
fanquake added the label Tests on Oct 19, 2021
DrahtBot commented at 2:26 AM on October 20, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #23305 (test: refactor: add script_util helper for creating bare multisig scripts by theStack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
lsilva01 approved
lsilva01 commented at 9:30 PM on October 22, 2021: contributor

tACK e9ade03
MarcoFalke merged this on Oct 25, 2021
MarcoFalke closed this on Oct 25, 2021
sidhujag referenced this in commit c1a58db6c7 on Oct 25, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels