harmonize 2 init messages and remove one #2332

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:init_messages changing 1 files +2 −3

Diapolo commented at 10:50 PM on February 23, 2013: none
- harmonize the database related init messages
- as we have a thread for importing blocks, that init message is obsolete
in src/init.cpp:None in 78ed0b43d8 outdated
```
 607 | @@ -608,7 +608,7 @@ bool AppInit2()
 608 |  
 609 |      // ********************************************************* Step 5: verify wallet database integrity
 610 |  
 611 | -    uiInterface.InitMessage(_("Verifying wallet integrity..."));
 612 | +    uiInterface.InitMessage(_("Verifying wallet database..."));
```
laanwj commented at 8:06 AM on February 24, 2013:

Why add "database"? As we prefer shorter messages here, I'd think "Verifying wallet" is enough (if it doesn't overlap with another message).

Diapolo commented at 10:49 AM on February 24, 2013:

No problem with that, my intention was to make the 2 DBs distinguishable in the init messages, so revert this, but leave the message below?

laanwj commented at 7:00 AM on February 25, 2013:

I prefer to leave database off there too, after all you are making the message longer now

Diapolo commented at 8:12 AM on February 25, 2013:

Alright, so in the end this pull would be reduced to just the removed message, are you fine with that change?
BitcoinPullTester commented at 12:57 AM on February 25, 2013: none

Automatic sanity-testing: WARNING, see http://jenkins.bluematt.me/pull-tester/78ed0b43d88a24e139dc1b93fa02c52c9091d808 for binaries and test log.

This pull decreases total test coverage, please add unit tests to test all new code and help us add test cases for existing code. Coverage report can be found at http://jenkins.bluematt.me/pull-tester/78ed0b43d88a24e139dc1b93fa02c52c9091d808/bitcoin/src/total.coverage/
laanwj commented at 7:00 AM on February 25, 2013: member

Ugh, how can this reduce total test coverage?

harmonize 2 init messages and remove one

- harmonize the database related init messages
- as we have a thread for importing blocks, that init message is obsolete

e1ca89df1f

Diapolo commented at 8:19 AM on March 13, 2013: none

@laanwj I updated the pull, should be better now :).
BitcoinPullTester commented at 9:23 AM on March 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e1ca89df1fd986a580565f9fe724b86209e76f32 for binaries and test log.
Diapolo commented at 5:58 PM on March 17, 2013: none

@laanwj Perhaps you consider this also mergable then :)?
laanwj referenced this in commit b804f1cd56 on Mar 19, 2013
laanwj merged this on Mar 19, 2013
laanwj closed this on Mar 19, 2013
laudney referenced this in commit 9bcebc1189 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester