fuzz: Descriptor wallet #23334

pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:2110-fuzzWall changing 6 files +185 −10

MarcoFalke commented at 7:56 PM on October 21, 2021: member

Initial sketch to fuzz descriptor wallets. Can be improved in the future.
build: Inline FUZZ_SUITE_LDFLAGS_COMMON
This is a refactor
fadb44606f
DrahtBot added the label Build system on Oct 21, 2021
DrahtBot added the label Wallet on Oct 21, 2021
refactor: Use local args instead of global gArgs in CWallet::Create
Can be reviewed with --word-diff-regex=.
fa59d2ce5b
fuzz: Add wallet fuzz test fa7c6efca6
MarcoFalke force-pushed on Oct 22, 2021
MarcoFalke removed the label Build system on Oct 22, 2021
MarcoFalke added the label Tests on Oct 22, 2021
mjdietzx commented at 3:08 PM on October 27, 2021: contributor

Looks great so far. I was curious about the file name src/wallet/test/fuzz/notifications.cpp (specifically the notifications part), could you explain the logic behind that for my understanding?

Also, can you point me to where this test runs in the CI logs so I can take a look, haven't been able to find it yet?
MarcoFalke commented at 12:24 PM on October 28, 2021: member

(specifically the notifications part)

This test is using the blockConnected/blockDisconnected interface of the wallet. Those are referred to as "chain notifications" sometimes.

Also, can you point me to where this test runs in the CI logs so I can take a look, haven't been able to find it yet?

Ooops, it is not built by CI. Will fix.
ci: Build fuzz with libsqlite3-dev 11115169a1
MarcoFalke commented at 1:13 PM on October 28, 2021: member

Ok fixed, it is "running" here now: https://cirrus-ci.com/task/4611029003927552?logs=ci#L1359
mjdietzx commented at 3:12 PM on October 28, 2021: contributor

Code review ACK 1111516
DrahtBot commented at 7:15 PM on October 28, 2021: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
MarcoFalke merged this on Nov 5, 2021
MarcoFalke closed this on Nov 5, 2021
sidhujag referenced this in commit 41d1c2e69d on Nov 5, 2021
MarcoFalke deleted the branch on Nov 5, 2021

in src/wallet/test/fuzz/notifications.cpp:103 in 11115169a1

  98 | +    // those coins. Once the block is mined, the next tuple will have an empty
  99 | +    // block and the freshly mined coins.
 100 | +    using Coins = std::set<std::tuple<CAmount, COutPoint>>;
 101 | +    std::vector<std::tuple<Coins, CBlock>> chain;
 102 | +    {
 103 | +        // Add the inital entry

hebasto commented at 1:24 PM on November 7, 2021:

typo: inital ==> initial

DrahtBot locked this on Nov 7, 2022

Contributors

Labels

fuzz: Descriptor wallet #23334

Conflicts