refactor: Make GenTxid boolean constructor private #23336

1. 
   MarcoFalke commented at 10:36 am on October 22, 2021: member

   This boolean argument is either verbose (when used with a named arg) or unintuitive and dangerous (when used as a plain bool).

   Fix that by making the constructor private.

2. remove unused CTxMemPool::info(const uint256& txid) faeb9a5753
3. Make GenTxid boolean constructor private fa4ec1c0bd
4. MarcoFalke added the label Refactoring on Oct 22, 2021
5. 
   jnewbery commented at 11:19 am on October 22, 2021: member

   Concept ACK
6. 
   laanwj commented at 12:44 pm on October 22, 2021: member

   Code review ACK fa4ec1c0bdaef9f082a6661d7faf16149774e145 Checked that false→Txid and true→Wtxid is consistently changed.
7. 
   glozow commented at 1:09 pm on October 22, 2021: member

   code review ACK fa4ec1c0bdaef9f082a6661d7faf16149774e145

   verified is_wtxid=false -> Txid, true -> Wtxid

8. 
   jnewbery commented at 1:44 pm on October 22, 2021: member

   Code review ACK fa4ec1c0bdaef9f082a6661d7faf16149774e145

   Nice improvement. Thanks Marco!

9. MarcoFalke merged this on Oct 22, 2021
10. MarcoFalke closed this on Oct 22, 2021

    ---

11. MarcoFalke deleted the branch on Oct 22, 2021
12. sidhujag referenced this in commit 219b6d2926 on Oct 22, 2021
13. 
    hebasto commented at 6:51 am on October 28, 2021: member

    It looks like this PR causes #23368

    UPDATE. See #23403.

14. fanquake deleted a comment on Nov 2, 2021
15. MarcoFalke locked this on Nov 2, 2021

Contributors
MarcoFalke jnewbery laanwj glozow hebasto

Labels
Refactoring