tests: Add assert_less_than and assert_less_than_or_equal to test framework #23337
pull dougEfresh wants to merge 1 commits into bitcoin:master from dougEfresh:23119-assert_less changing 10 files +43 −21-
dougEfresh commented at 11:50 AM on October 22, 2021: contributor
-
tests: Add assert_less_than and assert_less_than_or_equal to test framework 2f9d6aa03f
- fanquake added the label Tests on Oct 22, 2021
- dougEfresh cross-referenced this on Oct 22, 2021 from issue tests: Use test framework utils where possible by vincenzopalazzo
-
vincenzopalazzo commented at 11:59 AM on October 22, 2021: none
NIT, IMO this change should be inside the #23127 it is not useful at all to make these changes in X different PRs as mentioned in different messages already and discussed on IRC.
-
dougEfresh commented at 12:12 PM on October 22, 2021: contributor
@vincenzopalazzo noob here. what would you like me to do? open a pr to your branch?
-
DrahtBot commented at 1:17 PM on October 22, 2021: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #23127 (tests: Use assert_equal* utils where possible by vincenzopalazzo)
- #22867 (test: Extend test coverage of BIP125 and document confusing/inconsistent behavior by mjdietzx)
- #17794 (test: Use assert_greater_than_or_equal helper method to aid debugging. by jbampton)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Oct 23, 2021 from issue test: Use assert_greater_than_or_equal helper method to aid debugging. by jbampton
- DrahtBot cross-referenced this on Oct 29, 2021 from issue test: Extend test coverage of BIP125 and document confusing/inconsistent behavior by mjdietzx
- dougEfresh closed this on Nov 2, 2021
- bitcoin locked this on Nov 2, 2022
