ci: Reuse pre-built docker builder image for rapid local CI iteration testing #23344

pull dougEfresh wants to merge 1 commits into bitcoin:master from dougEfresh:ci_reuse_container changing 1 files +13 −5
  1. dougEfresh commented at 11:21 AM on October 24, 2021: contributor

    Reuse the pre-built image, if available, to bypass most of ./ct/test/04_install.sh

    ct/test/04_install.sh can run once without impacting the rest of the CI flow. This change reuses the docker image that was already built with installed external packages/software. Useful for changing CI flow or verify their current changes don't break CI build without the need to push to remote github.

    This is a marginal improvement, it decreased my total time by about ~60 seconds for a local re-run. If you are iterating multiple times this can add to a decent amount of saved time.

  2. ci: Reuse pre-built docker builder image for rapid local CI iteration testing
    Reuse the pre-built image, if available, to bypass most of the ci/test/04_install.sh script
    17d51e63c2
  3. hebasto commented at 11:51 AM on October 24, 2021: member

    Do I understand correctly that this change is actually useful only when running CI tasks locally?

  4. dougEfresh commented at 12:16 PM on October 24, 2021: contributor

    Do I understand correctly that this change is actually useful only when running CI tasks locally?

    Correct. It is a convenience for those who change CI flow and want to verify locally.

  5. DrahtBot added the label Tests on Oct 24, 2021
  6. MarcoFalke commented at 1:45 PM on October 25, 2021: member

    Looks fragile, as this will fail to update /ro_base and probably break other stuff?

  7. dougEfresh commented at 7:13 PM on October 26, 2021: contributor

    Looks fragile, as this will fail to update /ro_base and probably break other stuff?

    Yup, it would break ro_base and other more subtle stuff. I'll close this and re-think this concept. I do like re-using the container, it helped me speed up local verification/testing.

  8. dougEfresh closed this on Oct 26, 2021

  9. DrahtBot locked this on Oct 30, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me