doc: fix `XOnlyPubKey::IsFullyValid` comment reference #23400

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202110-doc-fix_xonlypubkey_isvalid_comment changing 1 files +2 −2

theStack commented at 1:46 AM on October 31, 2021: member

The method name CreatePayToContract doesn't exist, very likely it was a (local) working title that was renamed to CreateTapTweak later.
DrahtBot added the label Docs on Oct 31, 2021
fanquake requested review from sipa on Nov 8, 2021

fix `XOnlyPubKey::IsFullyValid` comment reference

The method name `CreatePayToContract` doesn't exist, very likely it was
a (local) working title that was renamed to `CreateTapTweak` later.
Also mention `CheckTapTweak`.

037c9ee79b

in src/pubkey.h:233 in 1836a9b77f outdated

 229 | @@ -230,7 +230,7 @@ class XOnlyPubKey
 230 |      XOnlyPubKey& operator=(const XOnlyPubKey&) = default;
 231 |  
 232 |      /** Determine if this pubkey is fully valid. This is true for approximately 50% of all
 233 | -     *  possible 32-byte arrays. If false, VerifySchnorr and CreatePayToContract will always
 234 | +     *  possible 32-byte arrays. If false, VerifySchnorr and CreateTapTweak will always

sipa commented at 11:22 PM on November 8, 2021:

Maybe also mention CheckTapTweak?

theStack commented at 11:42 AM on November 9, 2021:

Good idea, done.

theStack force-pushed on Nov 9, 2021
michaelfolkson commented at 11:49 AM on November 9, 2021: contributor

ACK 037c9ee79bae772ba951cdee6cb678a3264abe8b

This is the only reference to CreatePayToContract in the codebase.
sipa commented at 2:48 PM on November 9, 2021: member

ACK 037c9ee79bae772ba951cdee6cb678a3264abe8b
MarcoFalke merged this on Nov 9, 2021
MarcoFalke closed this on Nov 9, 2021
theStack deleted the branch on Nov 9, 2021
sidhujag referenced this in commit f4c309d209 on Nov 10, 2021
DrahtBot locked this on Nov 9, 2022

Contributors

Labels